refactor: AOI tool to monorepo pattern + event triggered panel#124
Open
BhattaraiSijan wants to merge 1 commit into
Open
refactor: AOI tool to monorepo pattern + event triggered panel#124BhattaraiSijan wants to merge 1 commit into
BhattaraiSijan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor the AOI (Area of Interest) tool to the monorepo tool pattern — a portable
lib/of presentational React components with all MMGIS coupling isolated inadapters/— and make the selection panel open on demand from the Title plugin instead of showing eagerly. No change to the tool's capabilities (search / inspect / draw / upload / analyze).Proposed Changes
lib/geo/*components +lib/styles/components-geo/*, MMGIS glue inadapters/, state + bus wiring inMMGISAOIAdapter.tsx, thinAOITool.tsxmount wrapper, and ametadatablock inconfig.json.AOITool.jsto React 19createRoot+ TypeScript; migrate styling to BEM (blocks-aoi-*) with USWDS--theme-*design tokens (Path A theming)._shared/adapters/mmgisAPI(no tool-local bus copy); split pure helpers intoadapters/{search,parse,geometry,slug}.ts.plugin:title:analyzeAreaBtnClicked(OPEN_PANEL_CHANNEL); the adapter stays mounted and listening while hidden. The in-tooltip "Analyze area" → statistics trigger is unchanged.react-domrender/unmountComponentAtNodepath (incompatible with React 19) along with the oldAOIComponent/andAOITool.js.Issues
Testing
npm run typecheck→ 0 errors.window.mmgisAPI.emit('plugin:title:analyzeAreaBtnClicked')reveals the panel; all four modes (search / inspect / draw / upload), selection → tooltip → analyze, and fit-bounds verified in browser.