Skip to content

fix: Identifying files for staging publish#411

Merged
aliziel merged 5 commits into
mainfrom
fix/identify-files-publish
Aug 1, 2025
Merged

fix: Identifying files for staging publish#411
aliziel merged 5 commits into
mainfrom
fix/identify-files-publish

Conversation

@aliziel

@aliziel aliziel commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

What I am changing

We recently changed the means by which we identify new files for staging publish (context) and the first few attempts on GitHub's runners have surfaced an issue with the git diff command:

https://github.com/NASA-IMPACT/veda-data/actions/runs/16653983094/job/47134015687#step:4:13

How I did it

  • Modify actions/checkout parameters to include full git context (defaults to only the merge commit)
  • Adjust refs used in <base>...<head>
  • Use git diff paths instead

How you can test it

Test PR: #412
Published: https://staging.openveda.cloud/stac/collections/campfire-nlcd-TEST-DIFF

  1. Push a commit to this branch commenting out the target branch on the staging publish workflow (here)
  2. Create or modify a dataset and collection
  3. Open a PR against fix/identify-files-publish (this branch)
    Expect → Publish collection to staging workflow to kick off
    Expect → all changed or modified files to be listed in List all newly added and changed files step in GitHub Actions workflow (example)
    Expect → veda_collection_pipeline run to kick off
    Expect → veda_dataset_pipeline run to kick off
  4. Reset target branch constraint on this branch and delete STAC artifacts from staging catalog

@aliziel aliziel marked this pull request as ready for review August 1, 2025 01:22
@aliziel aliziel requested a review from smohiudd as a code owner August 1, 2025 01:22
@aliziel aliziel requested review from anayeaye and removed request for smohiudd August 1, 2025 01:22
@aliziel aliziel merged commit f03e70b into main Aug 1, 2025
2 checks passed
aliziel added a commit that referenced this pull request Aug 4, 2025
* Create ingestion-data/staging/dataset-config/delta-disasters-planet-flood.json

* update via UI

* fix: Identifying files for staging publish (#411) (#414)

* Apply suggestions from code review

---------

Co-authored-by: veda-github-actor[bot] <192275278+veda-github-actor[bot]@users.noreply.github.com>
Co-authored-by: Alexandra Kirk <alexandra@developmentseed.org>
Co-authored-by: aliziel <21992503+aliziel@users.noreply.github.com>
aliziel added a commit that referenced this pull request Aug 4, 2025
* Create ingestion-data/staging/dataset-config/delta-disasters-planet-tornado.json

* update via UI

* fix: Identifying files for staging publish (#411) (#415)

* Apply suggestions from code review

---------

Co-authored-by: veda-github-actor[bot] <192275278+veda-github-actor[bot]@users.noreply.github.com>
Co-authored-by: Alexandra Kirk <alexandra@developmentseed.org>
Co-authored-by: aliziel <21992503+aliziel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants