Harden ingest PR filtering and ref path resolution#276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens the Edit Ingest flow to prevent non-Github app PRs from being treated as editable ingests, and fixes ref normalization when resolving ingest JSON files.
Context
I saw a retrieve-ingest failure when a manual PR with non-standard refs (for example, collection/GEDI) was included in Edit Collection results. The UI then attempted to resolve a file path from that ref and GitHub Contents returned Not Found.
What Changed
ListPRs.ts]collection Ingest Request forordataset Ingest Request forRetrieveJSON.tsListPRs.test.tsRetrieveJSON.test.tsListPRsFallback.test.tsBehavior Change
Before:
Manual/non-conforming PRs could appear in Edit Ingest lists if they touched target paths.
Some refs produced incorrect file paths and caused retrieve-ingest failures.
After:
Only app-authored or convention-conforming PRs are eligible in list-ingests.
retrieve-ingest resolves ref-to-filename more defensively and consistently.