Fixes to support tranfer of empty files - #246
Merged
Merged
Conversation
sdcolli1
requested review from
nutjob4life,
tloubrieu-jpl and
viviant100
as code owners
July 28, 2025 16:44
nutjob4life
approved these changes
Jul 28, 2025
nutjob4life
left a comment
nutjob4life
left a comment
Member
There was a problem hiding this comment.
- Code analysis ✓
- Tests run and doc builds via
tox✓ - Pre-commit hooks ✓
- Conclusion ✅
Thanks @collinss-jpl! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This branch makes several modifications to the DUM client and lambda function to properly support transfer of empty files to S3 via pre-signed URL.
⚙️ Test Data and/or Report
The localstack integration test suite has been updated to include an additional test case for transferring an empty file.
No changes to the unit test suite.
https://github.com/NASA-PDS/data-upload-manager/actions/runs/16574851781/job/46876465385#step:5:459
♻️ Related Issues
Fixes #241