Fix delete-dd -ns second query filtering on attr_ns instead of class_ns - #193
Merged
Conversation
Copy-paste bug: the second DeleteByQuery in deleteByNamespace() filtered on class_ns again instead of attr_ns, so only docs where class_ns matched were ever deleted. Sentinel docs (class_ns="registry", attr_ns=<ns>) and cross-namespace attribute refs were never touched. Also bumps registry-common dependency to 2.5.0-SNAPSHOT to pick up the AOSS delete-by-query pagination fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
nutjob4life
approved these changes
Jul 26, 2026
nutjob4life
left a comment
nutjob4life
left a comment
Member
There was a problem hiding this comment.
Code delta: ✓
Tests: ✓
Approval: ✅
Maven details:
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running tt.TestDDParsers
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 s -- in tt.TestDDParsers
[INFO] Running tt.TestLddLoader
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in tt.TestLddLoader
[INFO] Running tt.TestSchemaDao
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in tt.TestSchemaDao
[INFO] Running tt.TestDataLoader
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s -- in tt.TestDataLoader
[INFO] Running tt.TestRegistryDao
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in tt.TestRegistryDao
[INFO] Running tt.TestIndexDao
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in tt.TestIndexDao
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14.440 s
[INFO] Finished at: 2026-07-26T13:31:50-05:00
[INFO] ------------------------------------------------------------------------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteDDCmd.deleteByNamespace(): copy-paste bug where the secondDeleteByQueryfiltered onclass_nsagain instead ofattr_ns. This meant only field docs whereclass_nsmatched were deleted — sentinel docs (class_ns="registry",attr_ns=<ns>) and cross-namespace attribute refs were silently skipped on everydelete-dd -nscall.registry-commonto2.5.0-SNAPSHOTto pick up the AOSS delete-by-query pagination fix (Fix AOSS delete-by-query pagination and progress logging registry-common#303).Test plan
registry-manager delete-dd -ns <namespace>and confirm sentinel doc (registry:LDD_Info/<ns>:*.JSON) is also deletedattr_ns=<ns>butclass_nsfrom a different namespace are also removed🤖 Generated with Claude Code