Skip to content

registry-api#745: skip broken tests so we can continue with a majority of integration tests - #495

Merged
jordanpadams merged 2 commits into
developfrom
api-745
Mar 27, 2026
Merged

registry-api#745: skip broken tests so we can continue with a majority of integration tests#495
jordanpadams merged 2 commits into
developfrom
api-745

Conversation

@al-niessner

@al-niessner al-niessner commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

🗒️ Summary

Shortest route to getting most of the testing going again on registry-api

🤖 AI Assistance Disclosure

  • No AI assistance used
  • AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
  • AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
  • AI generated substantial portions of this code

Estimated % of code influenced by AI: ___ %

⚙️ Test Data and/or Report

Skips 20 tests that are related to product/{id}/member* and was going down a deep dark hole. Save those for another day, but get the 140 going.

♻️ Related Issues

NASA-PDS/registry-api#745

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
  • Issue Traceability: The PR is linked to a valid GitHub Issue
  • PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@al-niessner al-niessner self-assigned this Mar 27, 2026
@al-niessner
al-niessner requested a review from a team as a code owner March 27, 2026 16:55
@al-niessner

Copy link
Copy Markdown
Contributor Author

@jordanpadams @nutjob4life

Can I get a quick merge on this then a rebuild of all of the docker images so that I have fresh stuff to test registry-api and get it going?

I see that I have registry privs to merge, but how are the docker images made? One review from either of you and I will merge and hope for the best.

@al-niessner al-niessner mentioned this pull request Mar 27, 2026
@jordanpadams jordanpadams changed the title api 745: skip broken tests registry-api#745: skip broken tests Mar 27, 2026
@jordanpadams jordanpadams changed the title registry-api#745: skip broken tests registry-api#745: skip broken tests so we can continue with a majority of integration tests Mar 27, 2026
@jordanpadams
jordanpadams merged commit 08e05ab into develop Mar 27, 2026
1 check passed
@jordanpadams
jordanpadams deleted the api-745 branch March 27, 2026 17:48
@nutjob4life

Copy link
Copy Markdown
Member

@al-niessner I was in a meeting; but @jordanpadams quicky got the merge done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants