Skip to content

update sweepers command to reflect ENTRYPOINT directive introduced in… - #545

Merged
alexdunnjpl merged 1 commit into
developfrom
sweepers-entrypoint-fix
Jul 14, 2026
Merged

update sweepers command to reflect ENTRYPOINT directive introduced in…#545
alexdunnjpl merged 1 commit into
developfrom
sweepers-entrypoint-fix

Conversation

@alexdunnjpl

Copy link
Copy Markdown
Contributor

… 2b83e392

🗒️ Summary

2b83e392 switches the registry-sweepers Dockerfile to an ENTRYPOINT directive, resulting in duplication of the script when run as dockerized registry.

@tloubrieu-jpl was this change intentional? If not, please close this PR no-op and PR a reversion to the sweepers change.

🤖 AI Assistance Disclosure

  • No AI assistance used
  • AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
  • AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
  • AI generated substantial portions of this code

Estimated % of code influenced by AI: ___ %

⚙️ Test Data and/or Report

Manually tested

♻️ Related Issues

TBD

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
  • Issue Traceability: The PR is linked to a valid GitHub Issue
  • PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@alexdunnjpl
alexdunnjpl requested a review from a team as a code owner July 14, 2026 19:13

@nutjob4life nutjob4life left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker Composition file delta: ✓
Approval: ✅ (based on visual inspection only—trust accordingly)
Extra icing: 🧁

@alexdunnjpl

Copy link
Copy Markdown
Contributor Author

Delaying merge until @tloubrieu-jpl has confirmed whether this PR is actually desirable

@alexdunnjpl
alexdunnjpl merged commit d6fc7e2 into develop Jul 14, 2026
1 check passed
@alexdunnjpl
alexdunnjpl deleted the sweepers-entrypoint-fix branch July 14, 2026 20:59
@alexdunnjpl

Copy link
Copy Markdown
Contributor Author

Merge was no-op as my develop was out of date and this fix was already merged in https://github.com/NASA-PDS/registry/pull/528/changes#diff-423deb13b7c401b1a7f41ee91c77f722e11d2f317d6a66b546524e8a04cc8b03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants