Skip to content

Bugfix 131 main_v5.0 remove duplication - #132

Merged
jprestop merged 2 commits into
main_v5.0from
bugfix_131_main_v5.0_remove_duplication
Aug 12, 2026
Merged

Bugfix 131 main_v5.0 remove duplication#132
jprestop merged 2 commits into
main_v5.0from
bugfix_131_main_v5.0_remove_duplication

Conversation

@jprestop

@jprestop jprestop commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    No testing has been done, other than confirming the lines were a duplication. Note that this line:
gpuErrchk( cudaPeekAtLastError() ); /*Check for errors in the cudaMalloc calls*/

was moved as it was not duplicated and would have been lost with the removal of the initial set.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the file changed.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [Hopefully]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [At your convenience].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the FastEddy 5.0 milestone Aug 5, 2026
@jprestop
jprestop requested a review from jsauer-NCAR August 5, 2026 21:56
@jprestop jprestop added pillar: applications Applications pillar issue priority: high High Priority requestor: Multiscale NWP Team Multiscale NWP Team type: bug Fix something that is not working labels Aug 5, 2026
Comment thread SRC/HYDRO_CORE/CUDA/cuda_hydroCoreDevice.cu
@jprestop
jprestop requested a review from jsauer-NCAR August 10, 2026 18:34
@jprestop
jprestop merged commit 3a9ef61 into main_v5.0 Aug 12, 2026
1 check passed
@jprestop
jprestop deleted the bugfix_131_main_v5.0_remove_duplication branch August 12, 2026 20:21
@jprestop jprestop linked an issue Aug 12, 2026 that may be closed by this pull request
17 tasks
jprestop added a commit that referenced this pull request Aug 13, 2026
* Per #131, removed duplicate lines and moved gpuErrchk line which would have been lost in the deletion.

* Per #131, removing the added gpuErrchk because it is already called at the end of the routine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pillar: applications Applications pillar issue priority: high High Priority requestor: Multiscale NWP Team Multiscale NWP Team type: bug Fix something that is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugfix: Remove twice allocated fields

2 participants