Skip to content

UGWP_v0: Scale cdmbgwd(1:2) by inverse square root of dx #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grantfirl merged 7 commits into from
Jun 17, 2026
+6 −3
Merged

UGWP_v0: Scale cdmbgwd(1:2) by inverse square root of dx #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c4dfa7
GW multiplication factors scaled by inverse square root of dx (#82)
May 14, 2026
17182da
Unify cdmbgwd0 and cdmbgwd (#83)
May 15, 2026
7ff8e06
Remove unnecessary line
matusmartini May 21, 2026
3a5fb9c
Multiply coefficients by a power of 10
matusmartini May 26, 2026
acb9ab9
Merge branch 'main' into cdmbgwd_scale_ugwp_v0
grantfirl Jun 17, 2026
06fd5c2
add Alex and Matus as codeowners for ugwp_v0
grantfirl Jun 17, 2026
20f294c
Merge branch 'main' into cdmbgwd_scale_ugwp_v0
grantfirl Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ physics/GWD/drag_suite.* @md
physics/GWD/gwdc.* @Songyou184 @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/gwdps.* @Songyou184 @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/rayleigh_damp.* @yangfanglin @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/ugwp_driver_v0.F90 @mdtoyNOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/ugwp_driver_v0.F90 @mdtoyNOAA @matusmartini @areinecke @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/ugwpv1_gsldrag.* @mdtoyNOAA @BoYang-NOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/ugwpv1_gsldrag_post.* @mdtoyNOAA @BoYang-NOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
physics/GWD/unified_ugwp* @mdtoyNOAA @grantfirl @rhaesung @Qingfu-Liu @dustinswales
Expand Down
7 changes: 5 additions & 2 deletions physics/GWD/ugwp_driver_v0.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,9 @@ SUBROUTINE GWDPS_V0(IM, km, imx, do_tofd, &
R = sqrt(rnom/rdem)
ZR = MAX( 2. - R, 0. )
sigres = max(sigmin, sigma(J))
if (hprime(J)/sigres > dxres) sigres = hprime(J)/dxres
mtbridge = ZR * sigres*ZLEN / hprime(J)
! Scale the blocking coefficient by the inverse square root of dxres
cdmb4 = cdmbgwd(1) * 100.0 / sqrt(sqrt(sparea(j)))
! dbtmp = cdmb4*mtbridge*max(cos(ang(i,k)), gamma(j)*sin(ang(i,k))) ! (4.15)-ifs
dbtmp = cdmb4*mtbridge*(bgam * cosang2 + cgam * sinang2) ! (4.16)-ifs
DB(I,K)= DBTMP * UDS(I,K)
Expand Down Expand Up @@ -621,7 +622,9 @@ SUBROUTINE GWDPS_V0(IM, km, imx, do_tofd, &
EFACT = MIN( MAX(EFACT,EFMIN), EFMAX )
!
COEFM = (1. + CLX(I)) ** (OA(I)+1.)
!

! Scale the cleff coefficient by the inverse square root of dxres
cleff = cdmbgwd(2) * 0.001 / sqrt(sqrt(sparea(j)))
XLINV(I) = COEFM * CLEFF ! effective kxw for Lin-wave
XLINGFS = COEFM * CLEFF
!
Expand Down