Skip to content

Patch fusion crash in historic land only simulation fix#1579

Open
glemieux wants to merge 1 commit into
NGEET:mainfrom
glemieux:noresm-cp-pr66-abs-err
Open

Patch fusion crash in historic land only simulation fix#1579
glemieux wants to merge 1 commit into
NGEET:mainfrom
glemieux:noresm-cp-pr66-abs-err

Conversation

@glemieux

Copy link
Copy Markdown
Contributor

Description:

Changing EDCanopyStructureMod.F90 to have relative rather than absolute error comparisons so that errors are not triggered by differences which are in the noise of r8 precisions numbers

Addresses NorESMhub/CTSM#223. Cherry-picked from NorESMhub/CTSM#66.

Collaborators:

@maritsandstad

Expectation of Answer Changes:

Description of generative AI usage (as necessary)

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

…elative error indicating differences below noise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

2 participants