Add output dimension: canopy layer x patch age x pft#1580
Open
walkeranthonyp wants to merge 1 commit into
Open
Add output dimension: canopy layer x patch age x pft#1580walkeranthonyp wants to merge 1 commit into
walkeranthonyp wants to merge 1 commit into
Conversation
Fixes: NA User interface changes?: add two new output variables and option for new output dimensions Code review: NA Testing: none, compiles, runs at a site but not tested Test suite: pathfinder, gcc Test baseline: Test namelist changes: Test answer changes: Test summary:
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new history variable type (vtype) 'site_canagepft_r8' / compound dimension in output file 'fates_levcnagpf' that is dimensioned by canopy layer, patch age class, and PFT.
Requires E3SM commit ffc91d2 to work, currently on: https://github.com/walkeranthonyp/E3SM/tree/walkeranthonyp/fates_output
Also adds two history variables FATES_CROWNAREA_APPF and FATES_CROWNAREA_CLAPPF
Collaborators:
Discussion with Jenny, Charlie
Expectation of Answer Changes:
None expected
Description of generative AI usage (as necessary)
None
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
User guide may need update if history variables or history variable types are listed
Test Results:
*CTSM (or) E3SM (specify which) baseline hash-tag: 5ac83789c0
*FATES baseline hash-tag: 83863e9
Test Output:
Works with site level simulation run for a single ad_spinup case