Skip to content

Change env var name #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francisco-videira-nhs merged 12 commits into from
Oct 7, 2025
Merged

Change env var name #173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e7ea643
Change env var name
francisco-videira-nhs Sep 26, 2025
6f006a7
fix env var name
francisco-videira-nhs Sep 29, 2025
6e5bf07
Merge remote-tracking branch 'origin/main' into feature/CCM-11188_2
francisco-videira-nhs Sep 29, 2025
c94892f
Refactor contracts and mappers
francisco-videira-nhs Oct 2, 2025
094289f
Merge remote-tracking branch 'origin/main' into feature/CCM-11188_2
francisco-videira-nhs Oct 2, 2025
989792f
Fix invalid error message
francisco-videira-nhs Oct 2, 2025
681ee2b
Clean up updateLetterStatus
francisco-videira-nhs Oct 2, 2025
8a8bcc4
Merge remote-tracking branch 'origin/main' into feature/CCM-11188_2
francisco-videira-nhs Oct 3, 2025
3a5da13
patchLetters to patchLetter
francisco-videira-nhs Oct 3, 2025
e2ae5fb
Fix sonar issues
francisco-videira-nhs Oct 3, 2025
520be45
Read headers in lower case
francisco-videira-nhs Oct 6, 2025
6d8228b
Merge remote-tracking branch 'origin/main' into feature/CCM-11188_2
francisco-videira-nhs Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/api/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ locals {

destination_arn = "arn:aws:logs:${var.region}:${var.shared_infra_account_id}:destination:nhs-main-obs-firehose-logs"

common_db_access_lambda_env_vars = {
common_lambda_env_vars = {
LETTERS_TABLE_NAME = aws_dynamodb_table.letters.name,
LETTER_TTL_HOURS = 24,
SUPPLIER_ID_HEADER = "nhsd-supplier-id"
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/api/module_lambda_get_letters.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module "get_letters" {
log_destination_arn = local.destination_arn
log_subscription_role_arn = local.acct.log_subscription_role_arn

lambda_env_vars = merge(local.common_db_access_lambda_env_vars, {
lambda_env_vars = merge(local.common_lambda_env_vars, {
MAX_LIMIT = var.max_get_limit
})
}
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/api/module_lambda_patch_letters.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module "patch_letters" {
log_destination_arn = local.destination_arn
log_subscription_role_arn = local.acct.log_subscription_role_arn

lambda_env_vars = merge(local.common_db_access_lambda_env_vars, {})
lambda_env_vars = merge(local.common_lambda_env_vars, {})
}

data "aws_iam_policy_document" "patch_letters_lambda" {
Expand Down