Skip to content

CCM-12672: Improve devcontainer build and update asdf#191

Merged
m-houston merged 10 commits intomainfrom
feature/update-asdf
Oct 15, 2025
Merged

CCM-12672: Improve devcontainer build and update asdf#191
m-houston merged 10 commits intomainfrom
feature/update-asdf

Conversation

@m-houston
Copy link
Copy Markdown
Contributor

@m-houston m-houston commented Oct 11, 2025

Enhance the devcontainer setup by updating SSL certificate handling, improving the Zsh configuration, and adding necessary dependencies for a quicker container build.

  • Move ruby installation to apt package to avoid slow rebuild from source on aarch64
  • Update asdf to latest version to avoid errors on install
  • Fix certificates to work with or without custom CA certs
  • Add aws-cli feature
  • Downgrade python pinned version to work with Proxygen

Tested on M1 Mac and GitHub Codepaces (x64)

@m-houston m-houston requested a review from a team as a code owner October 11, 2025 13:31
Copy link
Copy Markdown
Contributor

@francisco-videira-nhs francisco-videira-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Python version is important if we want to have the proxygen cli in the container, which we should probably do if we want a dev env 'out of the box'? I had to install in the host and had some issues with Python dependencies (lxml), which went away after fixing 3.12.11 on my home dir.

Since we're in devcontainer realm, I also had some issues with running the test data generator and npm / aws-cli. Installing the aws-cli on the host and running the data generator from there doesn't work for me, as it complains it's missing @esbuild/darwin-arm64 which is fair I think because the build is done on the Ubuntu devcontainer. So I was considering adding a devcontainer feature which installs the aws-cli to make it easier (https://github.com/NHSDigital/nhs-notify-supplier-api/pull/188/files#diff-24ad71c8613ddcf6fd23818cb3bb477a1fb6d83af4550b0bad43099813088686) - maybe it could merge with this branch if you agree?

Another thought is that we should probably have 2 of us with different architectures trying this devcontainer version before merging.

@m-houston m-houston changed the title Improve devcontainer build and update asdf CCM-12672: Improve devcontainer build and update asdf Oct 13, 2025
@m-houston
Copy link
Copy Markdown
Contributor Author

Another thought is that we should probably have 2 of us with different architectures trying this devcontainer version before merging.

Absolutely agree - codespaces is my go-to for a clean build environment, but we probably do want to check WSL works with this too.

maybe it could merge with this branch if you agree?

Thanks, I'll try combining that branch with this one and see what we get!

@m-houston m-houston merged commit d25a78d into main Oct 15, 2025
41 checks passed
@m-houston m-houston deleted the feature/update-asdf branch October 15, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants