CCM-12672: Improve devcontainer build and update asdf#191
Conversation
…mproved SSL certificate handling
…ipt to use combined global + custom certs
… additional dependencies
… additional dependencies
…mmand and refine PATH settings
…Env and updating PATH in Dockerfile
francisco-videira-nhs
left a comment
There was a problem hiding this comment.
Looks good to me.
Python version is important if we want to have the proxygen cli in the container, which we should probably do if we want a dev env 'out of the box'? I had to install in the host and had some issues with Python dependencies (lxml), which went away after fixing 3.12.11 on my home dir.
Since we're in devcontainer realm, I also had some issues with running the test data generator and npm / aws-cli. Installing the aws-cli on the host and running the data generator from there doesn't work for me, as it complains it's missing @esbuild/darwin-arm64 which is fair I think because the build is done on the Ubuntu devcontainer. So I was considering adding a devcontainer feature which installs the aws-cli to make it easier (https://github.com/NHSDigital/nhs-notify-supplier-api/pull/188/files#diff-24ad71c8613ddcf6fd23818cb3bb477a1fb6d83af4550b0bad43099813088686) - maybe it could merge with this branch if you agree?
Another thought is that we should probably have 2 of us with different architectures trying this devcontainer version before merging.
Absolutely agree - codespaces is my go-to for a clean build environment, but we probably do want to check WSL works with this too.
Thanks, I'll try combining that branch with this one and see what we get! |
Enhance the devcontainer setup by updating SSL certificate handling, improving the Zsh configuration, and adding necessary dependencies for a quicker container build.
Tested on M1 Mac and GitHub Codepaces (x64)