Conversation
infrastructure/terraform/components/api/event_source_mapping_status_updates_to_handler.tf
Outdated
Show resolved
Hide resolved
masl2
reviewed
Nov 12, 2025
infrastructure/terraform/components/api/event_source_mapping_status_updates_to_handler.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/api/iam_role_api_gateway_execution_role.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/api/module_lambda_post_letters_receiver.tf
Outdated
Show resolved
Hide resolved
masl2
previously approved these changes
Nov 12, 2025
c873697 to
2536071
Compare
a92b241 to
f747cc9
Compare
f747cc9 to
f4dfe28
Compare
e6b4e19 to
dbed0dc
Compare
masl2
approved these changes
Nov 18, 2025
sidnhs
reviewed
Nov 18, 2025
infrastructure/terraform/components/api/event_source_mapping_status_updates_to_handler.tf
Show resolved
Hide resolved
sidnhs
approved these changes
Nov 18, 2025
masl2
pushed a commit
that referenced
this pull request
Jan 5, 2026
* Add post letters endpoint * Fix names * Fix event mapper * Fix sqs * Fix arn * Fix sqs name * Fix param * Fix attempt * Fix attempt sqs * Fix attempt await * Clean up tests * Naming and minor refactor * Add duplicate validation * Change handler name * Fix unit tests Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.