Merged
Conversation
10 tasks
m-houston
previously approved these changes
Nov 12, 2025
masl2
previously approved these changes
Nov 13, 2025
infrastructure/terraform/modules/eventsub/cloudwatch_log_group_sns_delivery_logging_success.tf
Show resolved
Hide resolved
sidnhs
force-pushed
the
CCM-12995_AddingEventPubInfra
branch
from
3b0de61 to
0fed847
Compare
sidnhs
force-pushed
the
CCM-12995_AddingEventPubInfra
branch
from
558dbd7 to
fc20be1
Compare
masl2
approved these changes
Nov 19, 2025
masl2
requested changes
Nov 19, 2025
masl2
approved these changes
Nov 19, 2025
masl2
added a commit
that referenced
this pull request
Jan 5, 2026
* CCM-12995 Adding base eventPub Infra * CCM-12995: Adding sns topic policy for sub * CCM-12995: Adding sns topic policy for sub * CCM-12995: Adding sns topic policy for sub * CCM-12995 Adding base eventPub Infra * CCM-12995 Adding base eventPub Infra * CCM-12312: Fixing typo in kms policy * CCM-12995: Fix comment * CCM-12995: Update package-lock.json * CCM-12995: Update package-lock.json * CCM-12995: Revert python version back to 3.12 --------- Co-authored-by: sidnhs <siddharth.nair1@nhs.net> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Related:
https://github.com/NHSDigital/comms-mgr/pull/1052
https://github.com/NHSDigital/nhs-notify-internal/pull/465
NHSDigital/nhs-notify-eventbus#68
#240
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.