Skip to content

CCM-12915: Async Patch#251

Merged
francisco-videira-nhs merged 24 commits intomainfrom
feature/CCM-12915
Nov 19, 2025
Merged

CCM-12915: Async Patch#251
francisco-videira-nhs merged 24 commits intomainfrom
feature/CCM-12915

Conversation

@francisco-videira-nhs
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@francisco-videira-nhs francisco-videira-nhs changed the base branch from main to feature/CCM-12097 November 18, 2025 13:32
@masl2 masl2 changed the title Feature/ccm 12915 CCM-12915: Async Patch Nov 18, 2025
Base automatically changed from feature/CCM-12097 to main November 18, 2025 16:07
@francisco-videira-nhs francisco-videira-nhs requested a review from a team as a code owner November 18, 2025 16:56
stevebux
stevebux previously approved these changes Nov 19, 2025
Copy link
Copy Markdown
Contributor

@stevebux stevebux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment

sidnhs
sidnhs previously approved these changes Nov 19, 2025
@francisco-videira-nhs francisco-videira-nhs merged commit 4699df3 into main Nov 19, 2025
32 checks passed
@francisco-videira-nhs francisco-videira-nhs deleted the feature/CCM-12915 branch November 19, 2025 10:19
masl2 pushed a commit that referenced this pull request Jan 5, 2026
* Add post letters endpoint

* Fix names

* Fix event mapper

* Fix sqs

* Fix arn

* Fix sqs name

* Fix param

* Fix attempt

* Fix attempt sqs

* Fix attempt await

* Clean up tests

* Naming and minor refactor

* Add duplicate validation

* Change handler name

* Fix unit tests

* Change patch to return 202 and use sqs

* Add await

* Change mapper name

Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants