Skip to content

CCM-13160 add sapiadmins to infra owners#254

Merged
masl2 merged 3 commits intomainfrom
feature/CCM-13160_add-sapiadmins-infra-owners
Nov 18, 2025
Merged

CCM-13160 add sapiadmins to infra owners#254
masl2 merged 3 commits intomainfrom
feature/CCM-13160_add-sapiadmins-infra-owners

Conversation

@masl2
Copy link
Copy Markdown
Contributor

@masl2 masl2 commented Nov 18, 2025

Description

To prevent bottlenecks enable admin group to approve infrastructure changes.
Platform review is still preferred, especially where new infrastructure is implicated

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@masl2 masl2 requested a review from a team as a code owner November 18, 2025 15:48
@masl2 masl2 enabled auto-merge (squash) November 18, 2025 16:39
@masl2 masl2 merged commit cd57610 into main Nov 18, 2025
31 of 32 checks passed
@masl2 masl2 deleted the feature/CCM-13160_add-sapiadmins-infra-owners branch November 18, 2025 16:48
masl2 added a commit that referenced this pull request Jan 5, 2026
* suppress readme secrets false positive

* add supplier-api-admins to infra approvers

Signed-off-by: Mark Slowey <mark.slowey1@nhs.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants