CCM-15018: How to request a digital proof by bhansell1 · Pull Request #879 · NHSDigital/nhs-notify-web-template-management

bhansell1 · 2026-03-16T17:08:12Z

Description

adds a banner to direct users on how to request a proof for a digital template
adds a new page explaining how to request a proof
shows request proof banner when digitalProofing is off
shows send a test message banner when digitalProofing is on
shows banner (digiproofing or request a proof) on; preview-submitted-template, preview-template, /message-plans/preview-template]
updates send a test message link to no longer open in a new tab

Context

Type of changes

Refactoring (non-breaking change)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would change existing functionality)
Bug fix (non-breaking change which fixes an issue)

Checklist

I am familiar with the contributing guidelines
I have followed the code style of the project
I have added tests to cover my changes
I have updated the documentation accordingly
This PR is a result of pair or mob programming
If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

frontend/src/app/request-a-proof/[templateId]/page.tsx

…emplate-management into feature/CCM-15018-request-proof-link

frontend/src/content/content.ts

...test-team/template-mgmt-component-tests/sms/template-mgmt-preview-sms-page.component.spec.ts

tests/test-team/pages/template-mgmt-preview-base-page.ts

frontend/src/content/content.ts

...m/template-mgmt-component-tests/nhs-app/template-mgmt-preview-nhs-app-page.component.spec.ts

...-team/template-mgmt-component-tests/email/template-mgmt-preview-email-page.component.spec.ts

frontend/src/components/organisms/PreviewDigitalTemplate/PreviewDigitalTemplate.tsx

… routing is disabled

...s__/components/forms/PreviewNHSAppTemplate/__snapshots__/PreviewNHSAppTemplate.test.tsx.snap

...__tests__/components/forms/PreviewSMSTemplate/__snapshots__/PreviewSMSTemplate.test.tsx.snap

frontend/src/__tests__/components/organisms/__snapshots__/PreviewDigitalTemplate.test.tsx.snap

…emplate-management into feature/CCM-15018-request-proof-link

…dless

…reviews

…emplate-management into feature/CCM-15018-request-proof-link

alexnuttall · 2026-04-02T10:44:36Z

frontend/src/content/content.ts

 import type { ContentBlock } from '@molecules/ContentRenderer/ContentRenderer';
 import { getBasePath } from '@utils/get-base-path';
 import { markdownList } from '@utils/markdown-list';
+import { MarkdownToJSX } from 'markdown-to-jsx';


maybe re-export this from the util file, rather importing directly?

frontend/src/__tests__/components/forms/PreviewSMSTemplate/PreviewSMSTemplate.test.tsx

frontend/src/__tests__/components/forms/PreviewNHSAppTemplate/PreviewNHSAppTemplate.test.tsx

…emplate-management into feature/CCM-15018-request-proof-link

tests/test-team/helpers/template-mgmt-common.steps.ts

nicki-nhs · 2026-04-07T14:17:29Z

...eam/template-mgmt-routing-component-tests/sms/preview-sms-template.routing-component.spec.ts

+        `${baseURL}/templates/message-plans/choose-text-message-template/${digitalProofingEnabledMessagePlanId}/preview-template/${digitalProofingEnabledTemplateId}?lockNumber=0`
+      );
+
+      await assertTestMessageBannerVisible(


in these tests where we're ending on this assertion, can we click the link too so we can test the navigation? since we're now not doing it in the other test?

nicki-nhs · 2026-04-07T14:18:18Z

...late-mgmt-routing-component-tests/nhs-app/preview-nhs-app-template.routing-component.spec.ts

+        `${baseURL}/templates/message-plans/choose-nhs-app-template/${digitalProofingEnabledMessagePlanId}/preview-template/${digitalProofingEnabledTemplateId}?lockNumber=0`
+      );
+
+      await assertTestMessageBannerVisible(


same here, could update to add a assertAndClickTestMessageBanner we can use across all of them maybe?

nicki-nhs · 2026-04-07T14:18:51Z

...template-mgmt-routing-component-tests/email/preview-email-template.routing-component.spec.ts

+        `${baseURL}/templates/message-plans/choose-email-template/${digitalProofingEnabledMessagePlanId}/preview-template/${digitalProofingEnabledTemplateId}?lockNumber=0`
+      );
+
+      await assertTestMessageBannerVisible(


and this one

nicki-nhs · 2026-04-07T14:19:30Z

...t-team/template-mgmt-component-tests/template-mgmt-request-a-digital-proof.component.spec.ts

+      templateId: templateIds.NHS_APP,
+    },
+  ] as const) {
+    test(`should load page ${channelName}`, async ({ page, baseURL }) => {


Suggested change

test(`should load page ${channelName}`, async ({ page, baseURL }) => {

test(`should load page for ${channelName}`, async ({ page, baseURL }) => {

nicki-nhs · 2026-04-07T14:20:02Z

...t-team/template-mgmt-component-tests/template-mgmt-request-a-digital-proof.component.spec.ts

+        'Request a proof'
+      );
+
+      const backLink = page.getByRole('link', {


is it not the standard back link that exists on the base page?

frontend/src/__tests__/components/organisms/PreviewDigitalTemplate.test.tsx

bhansell1 added 3 commits March 16, 2026 14:40

CCM-15018: update message-callout content based on feature flags

0a2dd87

CCM-15018: add tests

0fdd300

CCM-15018: add page to accessibility route coverage

274b1d8

bhansell1 marked this pull request as ready for review March 17, 2026 14:00

bhansell1 requested a review from a team as a code owner March 17, 2026 14:00

bhansell1 added 2 commits March 17, 2026 17:10

CCM-15018: add link for approve letter proofs

31a35c2

CCM-15018: content

eca9c8e

alexnuttall reviewed Mar 18, 2026

View reviewed changes

frontend/src/app/request-a-proof/[templateId]/page.tsx Outdated Show resolved Hide resolved

alexnuttall previously approved these changes Mar 18, 2026

View reviewed changes

bhansell1 added 3 commits March 18, 2026 11:55

Merge branch 'main' of https://github.com/NHSDigital/nhs-notify-web-t…

01d0f85

…emplate-management into feature/CCM-15018-request-proof-link

trivvy

554b035

CCM-15018: remove channelSlug

7200475

bhansell1 dismissed alexnuttall’s stale review via 7200475 March 18, 2026 12:08

CCM-15018: lockfile mismatch

9d5947d

alexnuttall previously approved these changes Mar 18, 2026

View reviewed changes

chris-elliott-nhsd previously approved these changes Mar 19, 2026

View reviewed changes