Conversation
nicokant
marked this pull request as draft
January 9, 2026 12:12
nicokant
marked this pull request as ready for review
January 9, 2026 12:24
frafra
requested changes
Jan 12, 2026
frafra
left a comment
frafra
left a comment
Contributor
There was a problem hiding this comment.
It would be useful to have the centering and zoom level computed automatically.
| "icon": "https://s3-ext-1.nina.no/dms/maps/logosmall-BFfoJdyr.png", | ||
| "baseMap": "positron", | ||
| "layerOrder": [], | ||
| # TODO: make this configurable or automatic based on the resource |
Contributor
There was a problem hiding this comment.
Shouldn't this be automatically computed? mercantile did that, but it looks unmaintained. It might be possible to use morecantile, to get the minimum zoom level required to show the entire bbox, using https://developmentseed.org/morecantile/api/morecantile/models/#morecantile.models.TileMatrixSet.zoom_for_res
| req = getattr(wms, f"_{cn}__build_getmap_request")( | ||
| layers=[key], | ||
| styles=[""], | ||
| srs="EPSG:3857", |
Contributor
There was a problem hiding this comment.
That's assuming that the server can do EPSG:3857.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.