Fix: Rewrite checkbox string extraction to be case insensitive#210
Merged
Conversation
andybeet
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
Github changed its internal markdown language such that checked boxes now appear as a lowercase
[x]instead of a capital[X]. This broke the parsing of checkboxes in issues when building pages. I've used thestringr::regexwrapper function with the argumentignore_case = Tto make the parsing case insensitive. This wrapper tells otherstringrfunctions how to treat the pattern argument. In this case, it gives the instruction to treat the pattern as a case insensitive regular expression. The expression we match could change (there is now redundant case insensitivity) but this is a quicker patch for now.Types of changes
Reviewer instructions:
Quick review for proper structure and syntax. There are no changes to pages present here, just the underlying code. All pages will be rebuilt in a subsequent pull request, which will include this fix and the implementation most of the EDAB review feedback. A full rebuild of the book is beyond the scope of this patch.