Skip to content

Apply land fraction as land mask for IMS snow depth preprocessing#2079

Merged
CoryMartin-NOAA merged 8 commits into
developfrom
feature/imsproc_landfrac
Mar 10, 2026
Merged

Apply land fraction as land mask for IMS snow depth preprocessing#2079
CoryMartin-NOAA merged 8 commits into
developfrom
feature/imsproc_landfrac

Conversation

@jiaruidong2017

@jiaruidong2017 jiaruidong2017 commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Summary of the code changes in this PR:

  1. Use land fraction as land mask for consistency with the rest of GFS system
  2. Remove IMS derived snow observations over land ice
  3. Add low bound to snow density

This PR also avoid defining the snow_prepobs_path twice.

Issues

Resolves #2078

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C48_ufsenkf_atmDA
  • C96C48_hybatmDA

@jiaruidong2017
Use land fraction>50% as the land mask for IMS snow preprocessing
fac820e 
Remove derived IMS obs over landice
Add a low bound to snow density
@jiaruidong2017
Fix a compile error
3ed8235
CoryMartin-NOAA
CoryMartin-NOAA reviewed Feb 26, 2026
View reviewed changes
Comment thread utils/land/gdas_fv3jedi_calc_scf_to_ioda.cc Outdated
@jiaruidong2017 jiaruidong2017 mentioned this pull request Feb 27, 2026
Closed
ClaraDraper-NOAA
ClaraDraper-NOAA previously approved these changes Mar 3, 2026
View reviewed changes
Comment thread utils/land/gdas_fv3jedi_calc_scf_to_ioda.cc Outdated
Comment thread utils/land/gdas_fv3jedi_calc_scf_to_ioda.cc Outdated
@emcbot

emcbot commented Mar 3, 2026

Copy link
Copy Markdown

Automated GW-GDASApp Testing Results:
Machine: gaeac6

Start: Tue Mar  3 01:02:16 PM EST 2026 on gaea65
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Mar  3 01:23:11 PM EST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_ufsgsi_hybatmDA|C96_gcafs_cycled|C48_ufsenkf_atmDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Tue Mar  3 01:51:08 PM EST 2026
Tests: 100% tests passed, 0 tests failed out of 27

@CoryMartin-NOAA

CoryMartin-NOAA commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

will merge once @ClaraDraper-NOAA gives the green light

@CoryMartin-NOAA CoryMartin-NOAA merged commit b52d099 into develop Mar 10, 2026
6 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/imsproc_landfrac branch March 10, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@ClaraDraper-NOAA ClaraDraper-NOAA ClaraDraper-NOAA approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

@jiaruidong2017 jiaruidong2017

Labels

gaeac6-GW-RT-Passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use land fraction as land mask

5 participants

@jiaruidong2017 @emcbot @CoryMartin-NOAA @ClaraDraper-NOAA @RussTreadon-NOAA