[rrfs-nco] WARNING and email for failback#1541
Conversation
lgannoaa
requested review from
BenjaminBlake-NOAA,
MatthewPyle-NOAA and
ShunLiu-NOAA
as code owners
WeiWei-NCO
left a comment
WeiWei-NCO
left a comment
There was a problem hiding this comment.
Thanks, Lin. Do we have a test log for this change? I'm not sure but it looks like we could get multiple emails sometimes.
We would like only 1 email alert from each cycle. It's fine to get 1 for det and 1 for enkf, but not multiple from det.
|
We are unable to test this change due to the resource limitation on dev system. I have contacted James prior submit this PR and request his help to test. He indicated there is low risk. Hence this PR is submitted and approved by others. |
|
One minor thing is I think the mail.py utility needs to be used to send e-mail - is mentioned in the standards document. |
1. print WARNING msg in the log indicating that restart files are missing and the job is proceeding with older ones. 2. send out an email notifying NCO (and likely EMC) about the missing restart files. Using "gold standard" in provide WARNING message as described in PR 1522
lgannoaa
dismissed stale reviews from ShunLiu-NOAA and BenjaminBlake-NOAA
via
c0ebe98
lgannoaa
force-pushed
the
feature/three-hours-fallback-alert
branch
from
cdea64c to
c0ebe98
Compare
|
I have updated the email statement by using mail.py utility. |
|
@WeiWei-NCO @lgannoaa I'm happy to test this later today before we merge it. |
MatthewPyle-NOAA
changed the title
Did you test it, or if not, do you still want to? |
6 participants
It is designed to address:
Using "gold standard" in provide WARNING message as described in PR [rrfs-nco] Adds warning for no RAVE data being available, and clarifies other warnings. #1522
Original issue [rrfs-nco] Alert when performing a failback #1427
Requirement:
export MAILTO= must be in run.ver to identify the target email address.