Is solo adot#1138
Conversation
|
|
||
| end subroutine update_shelf_mass | ||
|
|
||
| !>Update ice smb |
There was a problem hiding this comment.
In this comment, please use a space after the doxygen comment and explicitly spell out "surface mass balance" so that this reads:
!> Update the ice-shelf surface mass balance (SMB) field.
| if (CS%debug) call hchksum(SMB, "updatte_ice_SMB", CS%Grid_in%HI, haloshift=0) | ||
| endif | ||
|
|
||
| return |
There was a problem hiding this comment.
A return statement is not needed at the end of a subroutine, and generally should only be used for early exits.
|
|
||
| if (CS%time_varying_smb) then | ||
| call time_interp_external(CS%smb_file, Time, SMB) | ||
| if (CS%debug) call hchksum(SMB, "updatte_ice_SMB", CS%Grid_in%HI, haloshift=0) |
There was a problem hiding this comment.
Here "updatte_ice_SMB" should be "update_ice_SMB".
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
Thank you for this new capability, @MJHarrison-GFDL. There are a few very minor corrections that need to be made before this PR is ready to go, but I do not expect there to be any complications.
As written, the 4 commits will be squashed because at least one of the intermediate commits will not compile, but there could be a case for keeping this as a series of commits, provided that each commit in the series does lead to code that correctly compiles.
Hallberg-NOAA
added
enhancement
2 participants
Support for solo ice shelf driver allowing for time-varing surface mass balance input from file using the MOM_parameter ICE_SMB_TIME_VARYING = True.