Bug fix, if with .and. in argument#75
Merged
Merged
Conversation
- bug found with debug mode run crash - if(A.and.B) A and B are evaluated in any order, so B cannot be dependent on A in this case B refers to a variable that is undefined unless A is true cause crash in debug mode
alex-huth
approved these changes
Apr 20, 2026
alex-huth
left a comment
alex-huth
left a comment
Contributor
There was a problem hiding this comment.
Thank you for finding this bug. The fix looks correct (and mirrors what is done in the ice-shelf code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In " if (Sb_max_set .and. (Sbdry > Sb_max)) " Sb_max is not yet initialized when this is called for the first time,