Skip to content

Rovr crashes if directory has some broken symlinks #269

Description

@derVedro

Issue description

Well, as title say, rovr crashes on broken symlinks.

How do you reproduce it?

  1. cd /tmp
  2. mkdir somedir
  3. ln -s somedir samedir
  4. rm -r somedir
  5. rovr

What is the expected result of the steps?

Rovr would not crash, and should be more forgiving. May be mark the bad symlink red or something like that.

What actually happened after doing the steps?

Got FileNotFoundError and terminates.

Affected Operating System(s)

  • Windows
  • macOS
  • Linux

How can this be fixed?

Rovr should not terminate itself when encountering broken symlinks. Instead, it should simply indicate that the link is broken by highlighting the directory or file in the error or surface color. Perhaps an additional X icon would be appropriate.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething isnt working as intendeddifficulty: easythis feature is easy to implement, or this bug is easy to fix

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions