Skip to content

Rovr crashes if the current directory is deleted #272

Description

@NSPC911

Issue description

The issue happens if in a different terminal, you delete the folder that rovr is currently in, resulting in it not being able to get the current working directory, causing a crash.

How do you reproduce it?

  1. Go to /tmp
  2. Create a new directory mkdir test
  3. Open rovr there rovr /tmp/test
  4. Create a new terminal, delete the folder rm -rf /tmp/test
  5. Watch the crash happen

What is the expected result of the steps?

I expect it to be alive at least, realise that it is in a broken directory, and try up to as much parent directory as possible

What actually happened after doing the steps?

Death

Affected Operating System(s)

  • Windows
  • macOS
  • Linux

How can this be fixed?

Make change watcher keep the current directory as a variable, so if getcwd fails, keep going up the parent until something works. But if root doesn't work, just die, I will blame the end user for this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugsomething isnt working as intendedos:linuxthis affects linux distributions (please specify which!)os:macosthis affects mac os systems (specify your model, and os version!)

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions