-
Notifications
You must be signed in to change notification settings - Fork 28
Rovr crashes if the current directory is deleted #272
Copy link
Copy link
Closed
Labels
bugsomething isnt working as intendedsomething isnt working as intendedos:linuxthis affects linux distributions (please specify which!)this affects linux distributions (please specify which!)os:macosthis affects mac os systems (specify your model, and os version!)this affects mac os systems (specify your model, and os version!)
Description
Activity
Metadata
Metadata
Assignees
Labels
bugsomething isnt working as intendedsomething isnt working as intendedos:linuxthis affects linux distributions (please specify which!)this affects linux distributions (please specify which!)os:macosthis affects mac os systems (specify your model, and os version!)this affects mac os systems (specify your model, and os version!)
Issue description
The issue happens if in a different terminal, you delete the folder that rovr is currently in, resulting in it not being able to get the current working directory, causing a crash.
How do you reproduce it?
/tmpmkdir testrovr /tmp/testrm -rf /tmp/testWhat is the expected result of the steps?
I expect it to be alive at least, realise that it is in a broken directory, and try up to as much parent directory as possible
What actually happened after doing the steps?
Death
Affected Operating System(s)
How can this be fixed?
Make change watcher keep the current directory as a variable, so if getcwd fails, keep going up the parent until something works. But if root doesn't work, just die, I will blame the end user for this.