Skip to content

fix: drop unused second argument from run_notebook call - #14

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA-AI-Blueprints:mainfrom
andrewwhitecdw:codequality/ci-drop-unused-second-argument-from-run
Open

fix: drop unused second argument from run_notebook call#14
andrewwhitecdw wants to merge 1 commit into
NVIDIA-AI-Blueprints:mainfrom
andrewwhitecdw:codequality/ci-drop-unused-second-argument-from-run

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in .github/workflows/ci.yml: drop unused second argument from run_notebook call.

Changes

  • .github/workflows/ci.yml: drop unused second argument from run_notebook call.

Details

--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,1 +1,1 @@
-          run_notebook "deploy/2_TRTLLM_Checkpoints_Engines.ipynb" "fix_trtllm_path" || exit 1
+          run_notebook "deploy/2_TRTLLM_Checkpoints_Engines.ipynb" || exit 1

Tests

  • tests/test_ci_dead_code_arg.sh
--- /dev/null
+++ b/tests/test_ci_dead_code_arg.sh
@@ -0,0 +1,9 @@
+#!/bin/bash
+set -e
+WORKFLOW=".github/workflows/ci.yml"
+
+if grep -q 'run_notebook "deploy/2_TRTLLM_Checkpoints_Engines.ipynb" "fix_trtllm_path"' "$WORKFLOW"; then
+    echo "FAIL: run_notebook still receives unused second argument"
+    exit 1
+fi
+
+echo "PASS"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant