Fix FilePath service callbacks hanging in nvblox node#168
Open
shenfangqi123 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes FilePath-based services in
NvbloxNodehanging indefinitely when called from ROS 2.In
release-3.2, services such assave_map,save_rates, andsave_plycan enter their callbacks, but the ROS 2 client may never receive a response. During debugging, it was observed that FilePath service requests could block while waiting for queued work to complete, causing the service call to hang indefinitely in a component container setup.This change:
Testing
Tested with Isaac ROS Nvblox
release-3.2usingcomponent_container_isolated.Before this change:
/nvblox_node/save_rateshangs indefinitely/nvblox_node/save_maphangs indefinitely/nvblox_node/save_plyhangs indefinitelyAfter this change:
save_ratesreturnssuccess=Truesave_mapreturnssuccess=Trueand successfully writes a.nvblxfilesave_plyreturns normally instead of hangingTest Commands
Reproduction
The issue can be reproduced with: