Skip to content
Draft
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f5b8b39
fix: make disposition + validator schemas tolerant of small-model output
mvansegbroeck Apr 21, 2026
0a4df44
fix(disposition): coerce entity_label stuffed into category back to E…
mvansegbroeck Apr 21, 2026
669d189
fix(rewrite): tolerate verbose rationales and merged-enum hallucinations
mvansegbroeck Apr 21, 2026
fbaa6ba
fix(disposition): loosen category JSON schema so before-validator can…
mvansegbroeck Apr 21, 2026
121c8e2
fix(disposition): default protection_reason + let pydantic defaults a…
mvansegbroeck Apr 21, 2026
bbdb6dc
fix(disposition): reconcile needs_protection <-> method consistency rule
mvansegbroeck Apr 21, 2026
42992e5
refactor(disposition): delete unused combined_risk_level field + enum
mvansegbroeck Apr 21, 2026
f978fbd
refactor(disposition): add SimpleDispositionResult schema + reconstru…
mvansegbroeck Apr 21, 2026
2235b1e
refactor(disposition): switch LLM contract to simple schema + server-…
mvansegbroeck Apr 21, 2026
eb209ad
fix(disposition): reconstructor handles DD column shapes + trusts con…
mvansegbroeck Apr 21, 2026
792c9da
refactor(validator): loosen ValidationDecisionSchema wire contract
mvansegbroeck Apr 21, 2026
5b32f2e
fix(disposition): validate orphan-path source echo before trusting
mvansegbroeck Apr 21, 2026
94cb8e9
cleanup: drop=True on simple-disposition column + refresh class-K tes…
mvansegbroeck Apr 21, 2026
260ee41
refactor(evaluator): dedup + pad id-coverage schemas instead of rejec…
mvansegbroeck Apr 22, 2026
87ae1eb
refactor: loosen HIGH-severity schemas (Domain + MeaningUnit + Latent)
mvansegbroeck Apr 22, 2026
32e40a1
fix: class P (privacy reason >200) + class Q (empty sensitivity)
mvansegbroeck Apr 22, 2026
2a5c585
fix: class R (empty latent_entities list breaks parquet write)
mvansegbroeck Apr 22, 2026
cf19ca3
fix: belt-and-braces DataFrame-level sentinel for _latent_entities
mvansegbroeck Apr 23, 2026
19efe6e
docs: fix stale path comment in _ENTITY_LABEL_TO_CATEGORY
mvansegbroeck Apr 25, 2026
4bbfc8d
docs: drop unimplemented padding claim from _cap_rationale docstring
mvansegbroeck Apr 25, 2026
5a49381
docs: align MeaningUnitsSchema docstring with actual validators
mvansegbroeck Apr 25, 2026
b2420de
fix(disposition): pessimistic needs_protection default for high-risk …
mvansegbroeck Apr 25, 2026
bc67c1a
fix(meaning): renumber MeaningUnit ids on collision or omission
mvansegbroeck Apr 25, 2026
38aac1a
refactor(schemas): derive _ENTITY_LABEL_TO_CATEGORY from category sets
mvansegbroeck Apr 25, 2026
e98e7f2
refactor(disposition): move category normalization into reconstructor
mvansegbroeck Apr 25, 2026
097577a
refactor(schemas): drop _coerce_small_model_output, restore EntityCat…
mvansegbroeck Apr 25, 2026
c23c2e1
test: cover label coverage, privacy reason truncation, domain confide…
mvansegbroeck Apr 25, 2026
174266b
test: cover normalize_category, reconstructor reconciliation, and fla…
mvansegbroeck Apr 25, 2026
16bff86
test: cover _pad_empty_latent_column and value/label-less wire enrich…
mvansegbroeck Apr 25, 2026
ca08fb2
Merge origin/main into maarten/bugfix/small-model-support
mvansegbroeck Apr 25, 2026
8060c4c
style: apply ruff format to merge resolution
mvansegbroeck Apr 25, 2026
9d8674b
style: drop unused Domain import + sort schemas/__init__.py imports
mvansegbroeck Apr 25, 2026
dc0bc84
fix(disposition): tolerate bare-list shape from drifted small-model o…
mvansegbroeck Apr 25, 2026
576de6a
fix(validator): tolerate null proposed_label in RawValidationDecision…
mvansegbroeck Apr 26, 2026
5fa19b7
fix(validator): normalize free-form prose in RawValidationDecisionSch…
mvansegbroeck Apr 26, 2026
329d488
fix(meaning): tolerate bare-list shape on MeaningUnitsSchema
mvansegbroeck Apr 26, 2026
5e55aea
fix(disposition): close 4 review-flagged drift modes + harden reconst…
mvansegbroeck Apr 26, 2026
5e1cd08
style: ruff format on test_disposition_derivation.py
mvansegbroeck Apr 26, 2026
4a54b85
refactor(schemas): extract loose-list-wrapper helper + harden against…
mvansegbroeck Apr 26, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/anonymizer/engine/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
COL_DOMAIN = "_domain"
COL_DOMAIN_SUPPLEMENT = "_domain_supplement"
COL_DOMAIN_SUPPLEMENT_PRIVACY = "_domain_supplement_privacy"
COL_SIMPLE_DISPOSITION = "_simple_disposition"
COL_SENSITIVITY_DISPOSITION = "_sensitivity_disposition"
COL_SENSITIVITY_DISPOSITION_BLOCK = "_sensitivity_disposition_block"
COL_REWRITE_DISPOSITION_BLOCK = "_rewrite_disposition_block"
Expand Down
39 changes: 38 additions & 1 deletion src/anonymizer/engine/detection/detection_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
EntitiesByValueSchema,
EntitiesSchema,
LatentEntitiesSchema,
LatentEntitySchema,
ValidationDecisionsSchema,
)

Expand Down Expand Up @@ -208,7 +209,10 @@ def identify_latent_entities(
workflow_name="latent-entity-detection",
preview_num_records=preview_num_records,
)
return EntityDetectionResult(dataframe=latent_result.dataframe, failed_records=latent_result.failed_records)
return EntityDetectionResult(
dataframe=_pad_empty_latent_column(latent_result.dataframe),
failed_records=latent_result.failed_records,
)

def run(
self,
Expand Down Expand Up @@ -643,3 +647,36 @@ def _format_privacy_goal(privacy_goal: PrivacyGoal | None) -> str:
if privacy_goal is None:
return "Not provided"
return privacy_goal.to_prompt_string()


def _pad_empty_latent_column(df: pd.DataFrame) -> pd.DataFrame:
"""Inject a sentinel into any empty ``_latent_entities`` cell.

Downstream workflows write the DataFrame to parquet via DataDesigner,
which uses pyarrow. pyarrow raises ``Cannot write struct type with no
child field`` when every cell has ``latent_entities: []`` — it can't
infer the nested struct schema from only empty lists.
``LatentEntitiesSchema._ensure_parquet_writable`` covers this when
pydantic validation runs, but DD does not always route through
``model_validate`` (e.g. partial-failure fallback), so we pad again
at the DataFrame level.
"""
if COL_LATENT_ENTITIES not in df.columns:
return df
sentinel = [LatentEntitySchema().model_dump()]

def _fix(cell):
if isinstance(cell, dict):
if not cell.get("latent_entities"):
return {**cell, "latent_entities": sentinel}
return cell
if isinstance(cell, list) and not cell:
return sentinel
return cell

df = df.copy()
df[COL_LATENT_ENTITIES] = df[COL_LATENT_ENTITIES].map(_fix)
return df



269 changes: 269 additions & 0 deletions src/anonymizer/engine/rewrite/disposition_derivation.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,269 @@
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
"""Server-side reconstruction of the strict EntityDispositionSchema from the
loose wire-contract SimpleDispositionResult + the per-entity context columns.

The disposition_analyzer LLM now emits a minimal `SimpleDispositionResult`
(8 optional/loose fields per item). This module rebuilds the strict form
deterministically: pair each simple item with its entity context (by id,
with entity_label/value echoes as belt-and-braces), derive needs_protection,
and template protection_reason when the model did not provide one.

No LLM calls; no I/O. Pure python for the reconstruction column.
"""

from __future__ import annotations

import logging

from anonymizer.engine.schemas.rewrite import (
EntityDispositionSchema,
SensitivityDispositionSchema,
SimpleDispositionItem,
SimpleDispositionResult,
)

logger = logging.getLogger(__name__)


# ---------------------------------------------------------------------------
# Derivation helpers
# ---------------------------------------------------------------------------


def derive_needs_protection(method: str) -> bool:
"""Tautological with EntityDispositionSchema._validate_protection_consistency.

If the model picks any method other than leave_as_is, the entity needs
protection; otherwise it does not. Deriving this instead of asking the
LLM for it eliminates the consistency-rule drift (class K).
"""
return (method or "").strip() != "leave_as_is"


# (category, method) -> template text (without leading sensitivity prefix).
# Sensitivity fills a prefix ("high-risk ...", "moderate-risk ...", "").
_REASON_TEMPLATES: dict[tuple[str, str], str] = {
("direct_identifier", "replace"): "direct identifier — replaced with a contextual surrogate",
("direct_identifier", "remove"): "direct identifier — removed to prevent re-identification",
("direct_identifier", "generalize"): "direct identifier — generalized to reduce re-identification",
("direct_identifier", "suppress_inference"): "direct identifier — suppressed to prevent inference",
("quasi_identifier", "generalize"): "quasi-identifier — generalized to reduce re-identification risk",
("quasi_identifier", "replace"): "quasi-identifier — replaced with a plausible surrogate",
("quasi_identifier", "remove"): "quasi-identifier — removed due to re-identification risk",
("quasi_identifier", "suppress_inference"): "quasi-identifier — suppressed to prevent inference",
("sensitive_attribute", "remove"): "sensitive attribute — removed to prevent disclosure harm",
("sensitive_attribute", "generalize"): "sensitive attribute — generalized to reduce harm",
("sensitive_attribute", "suppress_inference"): "sensitive attribute — suppressed to prevent disclosure",
("sensitive_attribute", "replace"): "sensitive attribute — replaced with a less harmful value",
("latent_identifier", "suppress_inference"): "latent inference — suppressed to prevent deduction",
("latent_identifier", "remove"): "latent identifier — removed to prevent inference",
("latent_identifier", "generalize"): "latent identifier — generalized to reduce inference",
("latent_identifier", "replace"): "latent identifier — replaced with a less specific surrogate",
}

_SENSITIVITY_PREFIX = {"low": "", "medium": "moderate-risk ", "high": "high-risk "}


def template_protection_reason(category: str, method: str, sensitivity: str) -> str:
"""Build a reason string guaranteed ≥10 chars (EntityDispositionSchema min_length).

Used when the LLM omits or emits a too-short protection_reason. Strong
models that provide their own document-specific reason have theirs
kept verbatim by the reconstructor.
"""
method = (method or "").strip()
category = (category or "").strip()
sensitivity = (sensitivity or "").strip().lower()

if method == "leave_as_is":
cat_label = category.replace("_", " ") if category else "entity"
return f"Low-risk {cat_label}; retained as-is for utility."

base = _REASON_TEMPLATES.get((category, method))
if base is None:
cat_label = category.replace("_", " ") if category else "entity"
method_label = method or "an appropriate method"
base = f"{cat_label} — protected via {method_label}"

prefix = _SENSITIVITY_PREFIX.get(sensitivity, "")
reason = (prefix + base).strip()
Comment on lines +170 to +174

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Dead code in plural-stripping logic

The endswith("_identifiers") branch can never be reached for any of the intended inputs. The preceding endswith("s") check already handles "direct_identifiers", "quasi_identifiers", and "latent_identifiers" — their [:-1] forms are all in _VALID_CATEGORIES, so that check returns first. The _identifiers branch is only reached when normalized[:-1] is not in _VALID_CATEGORIES, in which case it returns an invalid category string that would cause a ValidationError downstream since EntityDispositionSchema.category has no before-validator. In practice unreachable for expected model output, but the dead code is misleading and could cause silent failures for hypothetical edge-case inputs.

# Capitalize first letter; template shapes already make this ≥10 chars.
return reason[:1].upper() + reason[1:] if reason else "Protection applied per policy."


# ---------------------------------------------------------------------------
# Entity-context flattening
# ---------------------------------------------------------------------------


def _coerce_entity_list(raw: object) -> list[dict]:
"""DataDesigner hands context columns to custom generators in several
shapes: a pydantic-dump dict with a keyed list, a raw list, a JSON-
encoded string, or None. Normalize to a plain list of dicts.
"""
import json
if raw is None:
return []
if isinstance(raw, str):
raw = raw.strip()
if not raw:
return []
try:
raw = json.loads(raw)
except Exception:
return []
if isinstance(raw, dict):
# pydantic dump of a wrapper schema like EntitiesByValueSchema or
# LatentEntitiesSchema — the inner list lives under one of these keys.
for key in ("entities_by_value", "latent_entities", "entities", "items"):
if key in raw and isinstance(raw[key], list):
raw = raw[key]
break
else:
return []
if not isinstance(raw, list):
return []
out: list[dict] = []
for item in raw:
if isinstance(item, dict):
out.append(item)
elif isinstance(item, str):
# JSON-string-per-item (rare but seen).
try:
parsed = json.loads(item)
if isinstance(parsed, dict):
out.append(parsed)
except Exception:
continue
return out


def _flatten_context(
entities_by_value: object,
latent_entities: object,
) -> list[dict]:
"""Produce a flat, ordered list of {source, entity_label, entity_value}.

Order matches how the disposition prompt enumerates entities:
tagged entries from entities_by_value (one per (value, label) pair)
followed by latent entries. The returned list index+1 is the expected id.
"""
flat: list[dict] = []
for ev in _coerce_entity_list(entities_by_value):
value = ev.get("value", "")
labels = ev.get("labels") or []
if not labels:
flat.append({"source": "tagged", "entity_label": "", "entity_value": value})
continue
for label in labels:
flat.append({"source": "tagged", "entity_label": label, "entity_value": value})
for le in _coerce_entity_list(latent_entities):
flat.append({
"source": "latent",
"entity_label": le.get("label", ""),
"entity_value": le.get("value", ""),
})
return flat


# ---------------------------------------------------------------------------
# Reconstruction
# ---------------------------------------------------------------------------


def reconstruct_full_disposition(
simple: SimpleDispositionResult,
entities_by_value: object = None,
latent_entities: object = None,
) -> SensitivityDispositionSchema:
"""Build the strict disposition from the loose LLM output + context columns.

For each SimpleDispositionItem:
- prefer the model-echoed source/entity_label/entity_value; fall back
to the id-indexed context lookup if the echo is missing or empty.
- derive needs_protection from method.
- keep the LLM protection_reason if it stripped to ≥10 chars, else
template one from (category, method, sensitivity).

Orphan simple items (id outside the context range AND no usable echoes)
are skipped with a warning — better to return a smaller valid schema
than to drop the whole record.
Duplicate ids are de-duplicated (first occurrence wins).
"""
context = _flatten_context(entities_by_value, latent_entities)
seen_ids: set[int] = set()
full_items: list[EntityDispositionSchema] = []

for item in simple.sensitivity_disposition:
if item.id in seen_ids:
logger.warning(
"reconstruct_full_disposition: duplicate id=%s in simple output; keeping first occurrence",
item.id,
)
continue
seen_ids.add(item.id)

# Resolve (source, entity_label, entity_value). Context is the
# AUTHORITATIVE source when the id falls in range — small models
# (gemma4-e2b) routinely echo garbage in these fields (e.g. the
# entity_label in the source slot), so trusting the echo there
# corrupts the strict schema. Fall back to the LLM echo only when
# there is no context entry for this id (orphan).
idx = item.id - 1
if 0 <= idx < len(context):
ctx = context[idx]
src = ctx["source"]
lbl = ctx["entity_label"]
val = ctx["entity_value"]
else:
# Orphan path: id has no context entry. The LLM echoes are the
# only source of truth, but they may be drifted (gemma4-e4b
# observed emitting prompt section names in source). Validate
# the source enum and skip the item if both source and labels
# are unusable — a skipped orphan is better than a ValidationError
# that drops the whole record.
echoed_src = (item.source or "").strip().lower()
src = echoed_src if echoed_src in {"tagged", "latent"} else ""
lbl = item.entity_label or ""
val = item.entity_value or ""

if not src or not lbl or not val:
logger.warning(
"reconstruct_full_disposition: orphan simple item id=%s "
"(missing or drifted source/label/value, out of context range); skipping",
item.id,
)
continue

# Derive derived fields.
method = (item.protection_method_suggestion or "").strip() or "leave_as_is"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the small model omits the method, this silently derives needs_protection=False, even for a direct_identifier with sensitivity="high". That's exactly the kind of failure mode this PR exists to fix — and it's inconsistent with the pessimistic defaults the PR uses elsewhere (e.g. PrivacyAnswersSchema pads missing with "yes", _normalize_decision defaults to "keep" = preserve detection).

Suggested fix — pessimistic default based on category/sensitivity:

Suggested change
method = (item.protection_method_suggestion or "").strip() or "leave_as_is"
raw_method = (item.protection_method_suggestion or "").strip()
if raw_method:
method = raw_method
elif category in ("direct_identifier", "sensitive_attribute") or sensitivity in ("medium", "high"):
method = "replace"
else:
method = "leave_as_is"

Add a test for SimpleDispositionItem(id=1, category="direct_identifier", sensitivity="high", protection_method_suggestion="") → reconstructed with needs_protection=True.

needs = derive_needs_protection(method)

# Keep LLM reason if usable, else template.
raw_reason = (item.protection_reason or "").strip()
reason = raw_reason if len(raw_reason) >= 10 else template_protection_reason(
item.category or "", method, item.sensitivity or ""
)

# Default empty LLM-drift slots to sane values so the strict schema
# doesn't reject the row. category/sensitivity are enums at the
# internal layer; empty strings would fail.
category = (item.category or "").strip() or "quasi_identifier"
sensitivity = (item.sensitivity or "").strip().lower() or "medium"

full_items.append(
EntityDispositionSchema(
id=item.id,
source=src,
category=category, # strict schema coerces via its before-validator
sensitivity=sensitivity,
entity_label=lbl,
entity_value=val,
needs_protection=needs,
protection_method_suggestion=method,
protection_reason=reason,
)
)

return SensitivityDispositionSchema(sensitivity_disposition=full_items)
14 changes: 8 additions & 6 deletions src/anonymizer/engine/rewrite/qa_generation.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,14 @@
)

# Derived from the schema so the Jinja key stays in sync with the field name.
_DOMAIN_KEY = next(
(name for name, info in DomainClassificationSchema.model_fields.items() if info.annotation is Domain),
None,
)
if _DOMAIN_KEY is None:
raise RuntimeError("DomainClassificationSchema must define a field annotated with Domain")
# The annotation on DomainClassificationSchema.domain was loosened from
# Domain to str as part of the wire-schema refactor; find the field by
# name + description hint instead of annotation class.
_DOMAIN_KEY = "domain"
if _DOMAIN_KEY not in DomainClassificationSchema.model_fields:
raise RuntimeError(
f"DomainClassificationSchema must define field {_DOMAIN_KEY!r}"
)

# ---------------------------------------------------------------------------
# Stage 1 pre-step: format disposition → disposition block
Expand Down
Loading
Loading