feat: replace MeaningUnitAspect enum with open-ended str

[asteier2026]

Summary

• Drops the MeaningUnitAspect enum from EntityDispositionSchema and schemas/__init__.py
• Changes MeaningUnitSchema.aspect from MeaningUnitAspect to str
• Updates tests to use string literals instead of enum values

Motivation

The enum was causing record loss: the model returns open-ended aspect values like "goal", "symptom", "diagnosis" that can't be exhaustively enumerated. Validation errors were silently dropping records.

[greptile-apps]

Greptile Summary

This PR removes the MeaningUnitAspect enum and replaces the aspect field with an open-ended str = Field(min_length=1) on both MeaningUnitSchema and QualityQAItemSchema, preventing silent record loss when the LLM returns aspect values outside a fixed vocabulary.

• rewrite.py: Drops the 16-value MeaningUnitAspect enum; aspect on MeaningUnitSchema becomes str = Field(min_length=1). QualityQAItemSchema.aspect also gains the min_length=1 guard as a bonus hardening.
• __init__.py: MeaningUnitAspect removed from the import and __all__ export list, keeping the public API consistent.
• test_qa_generation.py: Stub fixtures updated from enum references to plain string literals with no logic changes.

Confidence Score: 5/5

• This is a safe, well-scoped change that directly fixes silent record loss by relaxing an overly restrictive enum constraint.
• The change is minimal and targeted: removing a fixed-vocabulary enum and replacing it with a validated open string. Both affected fields now carry min_length=1 guards, the public API export is kept consistent, and tests are updated to match. No logic changes, no new code paths introduced.
• No files require special attention.

Important Files Changed

Filename	Overview
src/anonymizer/engine/schemas/rewrite.py	Removes MeaningUnitAspect enum and replaces aspect field with str = Field(min_length=1) on both MeaningUnitSchema and QualityQAItemSchema. No issues found.
src/anonymizer/engine/schemas/init.py	Removes MeaningUnitAspect from the import and __all__ list, consistent with the class removal in rewrite.py.
tests/engine/test_qa_generation.py	Removes MeaningUnitAspect import and replaces enum references with plain string literals in stub fixtures. Straightforward update with no issues.

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class MeaningUnitSchema {
        +int id
        +str aspect
        +str unit
        +MeaningUnitImportance importance
    }
    class QualityQAItemSchema {
        +int id
        +str aspect
        +MeaningUnitImportance importance
        +str question
        +str reference_answer
    }
    class MeaningUnitImportance {
        <<enumeration>>
        critical
        important
    }
    note for MeaningUnitSchema "aspect: str (min_length=1)\nreplaces MeaningUnitAspect enum"
    note for QualityQAItemSchema "aspect: str (min_length=1)\nalso hardened in this PR"
    MeaningUnitSchema --> MeaningUnitImportance
    QualityQAItemSchema --> MeaningUnitImportance

Loading

_{Reviews (4): Last reviewed commit: "fix: add min_length=1 to MeaningUnitSche..." | Re-trigger Greptile}

[lipikaramaswamy]

nit: could we add a regression test using an aspect outside the former enum, such as "diagnosis" or "goal"? The current "role" and "environment" fixtures were valid under the old enum, so they don’t directly verify the behavior this PR fixes.

[lipikaramaswamy]

LGTM on the code and tests (left a small nit), plus internal benchmark results support merging.