Skip to content

Support for SOAP optimizer - #16

Merged
skyw merged 10 commits into
NVIDIA-NeMo:mainfrom
mkhona-nvidia:mkhona-nvidia/soap_optimizer
Sep 25, 2025
Merged

Support for SOAP optimizer#16
skyw merged 10 commits into
NVIDIA-NeMo:mainfrom
mkhona-nvidia:mkhona-nvidia/soap_optimizer

Conversation

@mkhona-nvidia

Copy link
Copy Markdown
Contributor

This PR adds support for the SOAP optimizer

@copy-pr-bot

copy-pr-bot Bot commented Sep 24, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
@mkhona-nvidia
mkhona-nvidia force-pushed the mkhona-nvidia/soap_optimizer branch from fa856a0 to e46ab2f Compare September 24, 2025 20:01
Signed-off-by: mikail <mkhona@nvidia.com>
@skyw

skyw commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

/ok to test 90c5e2a

skyw
skyw previously approved these changes Sep 24, 2025
Signed-off-by: mikail <mkhona@nvidia.com>
@skyw
skyw self-requested a review September 24, 2025 22:49
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
Signed-off-by: mikail <mkhona@nvidia.com>
@skyw

skyw commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

/ok to test 88f0951

@skyw

skyw commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

/ok to test 88f0951

@skyw skyw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has previous been reviewed internally. approved.

@skyw
skyw merged commit 2fdbc22 into NVIDIA-NeMo:main Sep 25, 2025
23 of 30 checks passed
@skyw skyw mentioned this pull request Sep 25, 2025
@mkhona-nvidia
mkhona-nvidia deleted the mkhona-nvidia/soap_optimizer branch October 15, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants