Skip to content

Add option to use triton tsyrk_ex kernels in muon - #50

Merged
skyw merged 19 commits into
mainfrom
skyw/support_syrk_in_ns_step
Oct 9, 2025
Merged

Add option to use triton tsyrk_ex kernels in muon#50
skyw merged 19 commits into
mainfrom
skyw/support_syrk_in_ns_step

Conversation

@skyw

@skyw skyw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Something wrong with previous PR, opens a new one.

skyw added 14 commits October 8, 2025 19:48
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
skyw requested a review from a team as a code owner October 9, 2025 14:49
@skyw
skyw requested a review from gdengk October 9, 2025 14:50
@skyw skyw changed the title Support syrk in ns step Add option to use triton tsyrk_ex kernels in muon Oct 9, 2025
@copy-pr-bot

copy-pr-bot Bot commented Oct 9, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

skyw added 2 commits October 9, 2025 08:41
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
skyw force-pushed the skyw/support_syrk_in_ns_step branch from d524619 to 4857282 Compare October 9, 2025 15:49
@skyw

skyw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 4857282

Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw

skyw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 34ea499

gdengk
gdengk previously approved these changes Oct 9, 2025

@gdengk gdengk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
skyw force-pushed the skyw/support_syrk_in_ns_step branch from 390f354 to 4528425 Compare October 9, 2025 21:39
@skyw

skyw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 4528425

Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
skyw force-pushed the skyw/support_syrk_in_ns_step branch from b29635a to cd33eea Compare October 9, 2025 23:22
@skyw

skyw commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test cd33eea

@skyw
skyw merged commit df73f86 into main Oct 9, 2025
14 checks passed
@skyw
skyw deleted the skyw/support_syrk_in_ns_step branch October 9, 2025 23:47
pablo-garay pushed a commit that referenced this pull request Oct 10, 2025
Also fixed some testing related settings

Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants