feat (recipe): add Nemotron 3 Ultra pretraining perf-recipe - #4911
Conversation
|
/ok to test 8bcdd80 |
…GPUs with MXFP8 support - Introduced new configuration for Nemotron 3 Ultra pretraining on GB300 with 256 GPUs. - Added model and performance settings tailored for MXFP8 mixed precision. - Implemented necessary adjustments for Megatron-FSDP and HSDP compatibility. This enhances the training capabilities for large-scale models using the latest precision techniques. Signed-off-by: Ravi Ghadia <ghadiaravi13@users.noreply.github.com>
8bcdd80 to
b172461
Compare
|
/claude review |
|
Review — feat(recipe): add Nemotron 3 Ultra 256-GPU GB300 MXFP8 perf-recipe Scope: three files under perf_recipes/nemotronh/ — new shared builder + Ultra config helpers in common.py, the nemotron_3_ultra_pretrain_256gpu_gb300_fp8mx_v1_config entrypoint in gb300/nemotronh.py, and its init.py export. I verified every cfg.model.* / cfg.ddp.* / cfg.dist.* / cfg.scheduler.* attribute set in the diff resolves to a real config field (no phantom attributes), the base nemotron_3_ultra_pretrain_config alias exists, and the HSDP num_optim_instances = 256 // 64 = 4 -> outer_dp_sharding_strategy=optim logic is correct. Overall the change looks sound. A few small items: Low — inaccurate comment on cross-entropy impl (common.py:203-204) Low — missing blank line between top-level functions (gb300/nemotronh.py:164-165) Low — no test exercises the new config Suggested test cases
(No functional/GPU perf test is impacted — the only touched recipe targets 256 GPUs, above the 2-GPU CI limit; coverage is limited to config-instantiation.) |
…mance defaults - Renamed the ultra pretraining configuration for clarity. - Consolidated model configuration functions to enhance readability and maintainability. - Adjusted performance defaults for Nemotron 3 Ultra, including mixed precision settings and activation offloading. - moved gb300 specific overrides to nemotronh.py These changes improve the organization of the code and ensure better alignment with the latest training practices. Signed-off-by: Ravi Ghadia <ghadiaravi13@users.noreply.github.com>
4602c87 to
5b98974
Compare
|
/claude review |
|
Review — nemotron_3_ultra 256xGB300 MXFP8 perf recipe Light review. Well-structured; follows the Nemotron 3 Super GB300 pattern. HSDP/FSDP handling looks sound (guarding outer_dp_sharding_strategy=no_shard for a single NVLink domain, dtype overrides applied last). A few points:
Minor: trailing whitespace on a few added lines; run 'uv run ruff format' before merge. Suggested test cases:
|
|
A generic feedback is that agent tends to over-comment. Some comment provide no value as the code itself is self-explanatory. Also agents love to comment about irrelevant exploratory processes. e.g. we start this recipe from existing MLM jobs, and agent documents the argument translation to the comment, which provides no helpful information for a custom facing recipe. It shall comment on things that is helpful for custom to understand. This seems to be a common problem and we shall fix with a skill/guideline. |
…ved performance" This reverts commit 75d1868. Signed-off-by: Ravi Ghadia <ghadiaravi13@users.noreply.github.com>
48ab126
|
/ok to test d42338a |
…variables for better readability - Added detailed environment variable settings for the Nemotron 3 Ultra pretraining configuration - Updated expected recipe count in unit tests to reflect the addition of the new configuration. Signed-off-by: Ravi Ghadia <ghadiaravi13@users.noreply.github.com>
…ained activation offloading - Clarified the launch environment variable settings in the Nemotron 3 Ultra configuration. - Added required environment variables for fine-grained activation offloading and enabled the CuteDSL fused grouped MLP kernel. the setting of env vars based on config via perf_plugins.py was changed by commit cce4953 Signed-off-by: Ravi Ghadia <ghadiaravi13@users.noreply.github.com>
|
/ok to test 186c7fc |
Signed-off-by: malay-nagda <malayn@nvidia.com>
|
/ok to test 296eda1 |
What does this PR do ?
Add Nemotron 3 Ultra pretraining configuration for 256 GPUs with MXFP8 support
This enhances the training capabilities for large-scale models using the latest precision techniques.
Changelog
GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information