Update DeepSeek-V3 B300 recipe - #5015
Conversation
|
Review Light review of the DeepSeek V3 B300 perf-recipe retuning. Two issues, one CI-blocking. Critical - breaks perf-recipe env unit tests deepseek_v3_pretrain_256gpu_b300_fp8mx_large_scale_config was refactored to derive from the fp8mx config and no longer assigns cfg.env_vars inline. tests/unit_tests/recipes/test_perf_recipe_environment.py requires every canonical flat recipe builder to declare its env via an inline cfg.env_vars assignment:
The builder name matches the canonical regex, so both tests will fail. Every other large_scale config (b200/gb200/gb300) still keeps the inline env dict for this reason. Keep an inline cfg.env_vars here. Low - stale docstring on nvfp4 config deepseek_v3_pretrain_256gpu_b300_nvfp4_config docstring still says (PP=16 matching base layout), but the refactor dropped the PP=16/VPP=None overrides and the layout call, so it now inherits PP=8/VPP=2 from the bf16 base. Update the docstring. Notes (non-blocking)
Suggested test cases
(Perf configs touched are the B300 DeepSeek V3 recipes above; exercised by test_all_perf_recipe_factories and test_perf_recipe_environment offline construction tests rather than named _perf functional cases.) |
|
/ok to test f7f22a1 |
f7f22a1 to
bec3e1d
Compare
|
/ok to test bec3e1d |
Signed-off-by: Sanju C Sudhakaran <scsudhakaran@nvidia.com>
bec3e1d to
03d9d29
Compare
|
/ok to test 03d9d29 |
This PR updates B300 perf configs to align with #4458