fix: PEFT parameter statistics only count the first model chunk - #5562
Merged
cuichenx merged 6 commits intoAug 25, 2026
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
yaoyu-33
added
bug
Contributor
|
/ok to test 525f843 |
yaoyu-33
previously approved these changes
Aug 13, 2026
yaoyu-33
added
ready-to-merge
Contributor
|
@andrewwhitecdw Please address the CI failures, I will retrigger CI afterwards |
cuichenx
previously approved these changes
Aug 13, 2026
Contributor
|
/ok to test 188c86f |
Contributor
|
/ok to test ae35199 |
Contributor
|
@andrewwhitecdw Please address the CI failures |
Contributor
|
/ok to test 19726bc |
Contributor
|
@andrewwhitecdw Please check the CI failures |
Signed-off-by: adityavavreNVDA <avavre@nvidia.com>
adityavavreNVDA
dismissed stale reviews from yaoyu-33 and cuichenx
via
August 24, 2026 22:17
d1c9ac2
Contributor
|
/ok to test 8fcad42 |
cuichenx
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
src/megatron/bridge/training/setup.py: PEFT parameter statistics only count the first model chunk.Changes
src/megatron/bridge/training/setup.py: PEFT parameter statistics only count the first model chunk.Details
See the Files changed tab for the exact diff.
Tests
tests/unit_tests/bridge/training/test_setup.pyContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).