fix(ckpt): handle missing newer MLM checkpoint args - #5715
Open
caohch-1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: caohch-1 <caohch2023@shanghaitech.edu.cn>
caohch-1
marked this pull request as ready for review
August 20, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Make MLM checkpoint config loading tolerate older checkpoints whose saved
argparse.Namespacelacks newer optional Megatron-LM arguments.Changelog
cp_comm_type.TransformerConfigfields, and only map renamed checkpoint arguments when those source arguments are present.Validation
tests/unit_tests/training/mlm_compat/test_arguments.pytests pass.ruff checkpasses for both changed files.ruff format --checkpasses for both changed files.git diff --checkpasses.GitHub Actions CI
This is an external contribution, so GitHub Actions CI will require approval from an NVIDIA developer.
Before your PR is "Ready for review"
Pre checks:
Additional Information
Fixes #2127