fix(data): use Energon validation recipe for val split - #5727
Open
caohch-1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: caohch-1 <caohch2023@shanghaitech.edu.cn>
yaoyu-33
reviewed
Aug 22, 2026
| self.path, | ||
| batch_size=self.micro_batch_size, | ||
| task_encoder=task_encoder, | ||
| task_encoder=self.validation_task_encoder, |
Contributor
There was a problem hiding this comment.
validation_task_encoder will this always exist? or required
Author
There was a problem hiding this comment.
Yes. validation_task_encoder is initialized in __init__ as validation_task_encoder or self.task_encoder, so it falls back to the training task encoder when a separate validation encoder is not provided. The existing val path already used self.validation_task_encoder; this PR only changes the dataset builder from get_train_dataset() to get_val_dataset().
If both encoders are None in direct construction, the value can still be None, but that is pre-existing behavior and is not introduced by this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Use Energon's validation dataset recipe for the validation split instead of constructing validation data through the training recipe.
Changelog
get_train_dataset()and the validation split throughget_val_dataset().Validation
get_train_dataset()for validation and the updated implementation selectsget_val_dataset().get_train_dataset().git diff --checkpasses.GitHub Actions CI
This is an external contribution, so GitHub Actions CI will require approval from an NVIDIA developer.
Before your PR is "Ready for review"
Pre checks:
Additional Information
Fixes #5626