docs(misc): list EXAONE, Kimi K3, MiniMax-M3 and Nemotron-3 Ultra as supported - #5743
Open
pruprakash wants to merge 1 commit into
Open
docs(misc): list EXAONE, Kimi K3, MiniMax-M3 and Nemotron-3 Ultra as supported#5743pruprakash wants to merge 1 commit into
pruprakash wants to merge 1 commit into
Conversation
…supported The README Supported Models table is hand-maintained while docs/models/ and examples/ are updated by the PR that lands a model, so four families and variants shipped on main were absent from the repository landing page. Adds doc-consistency tests comparing the table against docs/models/ and the tree behind it (red-green verified). Detected by: megatron-bridge QA Signed-off-by: Pruthviraj Prakash <pruprakash@nvidia.com>
pruprakash
added
docs
Contributor
|
Light review — LGTM Docs-only + test-guard change. Verified against the working tree:
Minor observation (non-blocking): the EXAONE row links to docs/models/exaone/exaone.md (a page) rather than an index.md like sibling families — fine, since _row_for_family matches on the docs/models/exaone/ prefix and the file exists. Suggested test cases
|
Contributor
Author
|
/ok to test 0c18f77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds the four models a reader cannot find on the repository landing page: EXAONE, Kimi K3, MiniMax-M3 and Nemotron-3 Ultra ship on
mainwith published docs pages, but the README Supported Models table names none of them.Changelog
README.md: adds the EXAONE row linkingdocs/models/exaone/exaone.md; extends the Kimi, MiniMax and Nemotron rows with Kimi K3, MiniMax-M3 and Nemotron-3 Ultra.tests/unit_tests/doc_consistency/test_readme_consistency.py: 2 stdlib-only tests comparing the table againstdocs/models/and the tree behind it.Additional Information
docs/models/andexamples/are updated by the PR that lands a model; the README table is hand-maintained separately and nothing compared the two.HEAD~1) both new tests fail naming exactly the four omissions; GREEN (fix applied) 2/2 pass. Stdlib-only, so no GPU needed.k-exaone-2branch though the bridges are onmain— separate section, left to dev.