Skip to content

test: fix collection errors in kit and recipes tests #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewwhitecdw wants to merge 5 commits into from
Closed

test: fix collection errors in kit and recipes tests #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a45531
test: fix collection errors in kit and recipes tests
andrewwhitecdw Jul 1, 2026
f24d76a
Merge branch 'main' into fix-test-collection-errors
chrisalexiuk-nvidia Jul 6, 2026
37fa02e
Merge branch 'main' into fix-test-collection-errors
chrisalexiuk-nvidia Jul 8, 2026
e668136
Merge branch 'main' into fix-test-collection-errors
andrewwhitecdw Jul 15, 2026
8f38ef8
Merge branch 'main' into fix-test-collection-errors
andrewwhitecdw Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nemotron/cli/commands/super3/data/prep/_typer_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from __future__ import annotations

from nemotron.cli.commands.super3.data.prep.pretrain import META as PRETRAIN_META, pretrain
from nemotron.cli.commands.super3.data.prep.rl import META as RL_META, rl
from nemotron.cli.commands.super3.data.prep.rl import rl_app
from nemotron.cli.commands.super3.data.prep.sft import META as SFT_META, sft
from nemo_runspec.recipe_typer import RecipeTyper

Expand All @@ -43,4 +43,4 @@

prep_app.add_recipe_command(pretrain, meta=PRETRAIN_META)
prep_app.add_recipe_command(sft, meta=SFT_META)
prep_app.add_recipe_command(rl, meta=RL_META)
prep_app.add_typer(rl_app, name="rl")
5 changes: 3 additions & 2 deletions tests/kit/test_resolvers_pre_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,13 @@ def __init__(self, ref: str):
self.version = "v5"
self.name = "nano3-pretrain-data"
self.type = "dataset"
self.metadata = {}

def download(self, skip_cache: bool = True):
return str(downloaded_dir)

class FakeApi:
def __init__(self):
def __init__(self, timeout: int = 30):
self.last_ref = None

def artifact(self, ref: str):
Expand All @@ -115,7 +116,7 @@ def artifact(self, ref: str):
fake_api = FakeApi()

class FakeWandb(types.SimpleNamespace):
def Api(self): # noqa: N802
def Api(self, timeout: int = 30): # noqa: N802
return fake_api

monkeypatch.setitem(sys.modules, "wandb", FakeWandb())
Expand Down