fix: workflow file is missing the NVIDIA copyright header - #306
Open
andrewwhitecdw wants to merge 3 commits into
Open
Conversation
Signed-off-by: Andrew White <andrewh@cdw.com>
Auditor: tests/test_workflows.py contains an unrelated, incomplete test function that ends with an unfinished `if` statement, making it invalid Python that would break the test suite. The PR is not minimal and introduces a syntax error/off-scope check.
Auditor: The PR adds the requested copyright header, but it also pins action references to commit hashes across several unrelated workflow files (build_docs.yml, claude-review.yml, release-docs.yml, etc.) and includes an incomplete/unfinished regression test (test_skipping_is_allowed_is_defined_when_used ends mid-expression). These off-scope changes and malformed test make the PR not minimal or cleanly applicable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
.github/workflows/team-request.yml: workflow file is missing the NVIDIA copyright header.Changes
.github/workflows/team-request.yml: workflow file is missing the NVIDIA copyright header.Details
Tests
tests/test_workflows.pyContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).