Add initial CI - #7
Merged
Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
chtruong814
commented
Oct 24, 2025
| ignore = [] | ||
|
|
||
| [tool.ruff.format] | ||
| exclude = ["*.ipynb"] |
Contributor
Author
There was a problem hiding this comment.
Not sure if you want to apply ruff format to the notebooks. If so, we can remove this and apply the formatting.
Contributor
There was a problem hiding this comment.
@shashank3959 @chrisalexiuk-nvidia Any preferences for this? I feel like ruff formatting + spelling-checks would be good to enable for our notebooks
Collaborator
There was a problem hiding this comment.
Yeah, that's fine!
Contributor
Author
There was a problem hiding this comment.
Updated. Please take another look. I updated the ruff config to ignore too long lines in notebooks. That seems like it'd be ok to ignore.
Collaborator
There was a problem hiding this comment.
Awesome!
This looks good to me!
Contributor
Author
|
@marcromeyn if you're ok, would you mind approving? |
pablo-garay
approved these changes
Nov 4, 2025
marcromeyn
added a commit
that referenced
this pull request
Dec 15, 2025
* Fix broken links to usage-recipes (#9) Also updates a typo - usage cookbooks are now available, and examples are coming soon. Signed-off-by: Shashank Verma <shashank3959@gmail.com> * Final Pre-release commit (#10) * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * add Nemotron_Parse_V1_1.ipynb & Nemotron_Nano2_VL.ipynb to usage-cookbook * update Nemotron-Parse endpoint URL * docs: add Nemotron Ideas Portal feature voting section to README * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> * Final pre-release updates (#11) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Bug/rename notebook (#12) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13) Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> * Add Data Science ML Agent Use Case Example (#14) * Add Data Science ML Agent example Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Add data folder with .gitkeep Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README.md in use-case-examples Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README in ds ml agent Signed-off-by: Allison Ding <allison.j.ding@gmail.com> --------- Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Adding structure Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data_prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data-prep for nano-3 Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding nemotron.kit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Allowing defaults Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Integrate run Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fixing data prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Improving wandb artifact integration Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Various improvements Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes (#7) * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * End of day commit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Remove tui for now (#8) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Removing tui properly (#9) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Move data-prep configs (#10) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding structure (#11) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes for pre-training (#12) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fix linting Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Disable CI for now Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Shashank Verma <shashank3959@gmail.com> Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> Signed-off-by: Allison Ding <allison.j.ding@gmail.com> Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> Co-authored-by: Shashank Verma <shashank3959@gmail.com> Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn
pushed a commit
that referenced
this pull request
Dec 16, 2025
* Add initial CI Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix CI pull request target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix copyright Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add dev branch as GHA CI target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix uv install in GHA Signed-off-by: Charlie Truong <chtruong@nvidia.com> * ruff format ignores .ipynb Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Ignore ipynb files in pre-commit Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Ignore ipynb files in pre-commit" This reverts commit 41c4d94. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "ruff format ignores .ipynb" This reverts commit 5fcce7e. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Format notebooks Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
marcromeyn
added a commit
that referenced
this pull request
Dec 16, 2025
* Fix broken links to usage-recipes (#9) Also updates a typo - usage cookbooks are now available, and examples are coming soon. Signed-off-by: Shashank Verma <shashank3959@gmail.com> * Final Pre-release commit (#10) * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * add Nemotron_Parse_V1_1.ipynb & Nemotron_Nano2_VL.ipynb to usage-cookbook * update Nemotron-Parse endpoint URL * docs: add Nemotron Ideas Portal feature voting section to README * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> * Final pre-release updates (#11) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Bug/rename notebook (#12) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13) Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> * Add Data Science ML Agent Use Case Example (#14) * Add Data Science ML Agent example Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Add data folder with .gitkeep Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README.md in use-case-examples Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README in ds ml agent Signed-off-by: Allison Ding <allison.j.ding@gmail.com> --------- Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Adding structure Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data_prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data-prep for nano-3 Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding nemotron.kit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Allowing defaults Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Integrate run Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fixing data prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Improving wandb artifact integration Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Various improvements Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes (#7) * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * End of day commit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Remove tui for now (#8) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Removing tui properly (#9) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Move data-prep configs (#10) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding structure (#11) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes for pre-training (#12) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fix linting Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Disable CI for now Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Shashank Verma <shashank3959@gmail.com> Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> Signed-off-by: Allison Ding <allison.j.ding@gmail.com> Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> Co-authored-by: Shashank Verma <shashank3959@gmail.com> Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn
pushed a commit
that referenced
this pull request
Dec 18, 2025
* Add initial CI Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix CI pull request target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix copyright Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add dev branch as GHA CI target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix uv install in GHA Signed-off-by: Charlie Truong <chtruong@nvidia.com> * ruff format ignores .ipynb Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Ignore ipynb files in pre-commit Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Ignore ipynb files in pre-commit" This reverts commit 41c4d94. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "ruff format ignores .ipynb" This reverts commit 5fcce7e. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Format notebooks Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
marcromeyn
added a commit
that referenced
this pull request
Dec 18, 2025
* Fix broken links to usage-recipes (#9) Also updates a typo - usage cookbooks are now available, and examples are coming soon. Signed-off-by: Shashank Verma <shashank3959@gmail.com> * Final Pre-release commit (#10) * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * add Nemotron_Parse_V1_1.ipynb & Nemotron_Nano2_VL.ipynb to usage-cookbook * update Nemotron-Parse endpoint URL * docs: add Nemotron Ideas Portal feature voting section to README * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> * Final pre-release updates (#11) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Bug/rename notebook (#12) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13) Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> * Add Data Science ML Agent Use Case Example (#14) * Add Data Science ML Agent example Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Add data folder with .gitkeep Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README.md in use-case-examples Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README in ds ml agent Signed-off-by: Allison Ding <allison.j.ding@gmail.com> --------- Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Adding structure Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data_prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data-prep for nano-3 Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding nemotron.kit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Allowing defaults Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Integrate run Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fixing data prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Improving wandb artifact integration Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Various improvements Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes (#7) * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * End of day commit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Remove tui for now (#8) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Removing tui properly (#9) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Move data-prep configs (#10) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding structure (#11) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes for pre-training (#12) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fix linting Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Disable CI for now Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Shashank Verma <shashank3959@gmail.com> Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> Signed-off-by: Allison Ding <allison.j.ding@gmail.com> Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> Co-authored-by: Shashank Verma <shashank3959@gmail.com> Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
marcromeyn
pushed a commit
that referenced
this pull request
Mar 10, 2026
* Add initial CI Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix CI pull request target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix copyright Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Add dev branch as GHA CI target Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Fix uv install in GHA Signed-off-by: Charlie Truong <chtruong@nvidia.com> * ruff format ignores .ipynb Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Ignore ipynb files in pre-commit Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "Ignore ipynb files in pre-commit" This reverts commit 41c4d94. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Revert "ruff format ignores .ipynb" This reverts commit 5fcce7e. Signed-off-by: Charlie Truong <chtruong@nvidia.com> * Format notebooks Signed-off-by: Charlie Truong <chtruong@nvidia.com> --------- Signed-off-by: Charlie Truong <chtruong@nvidia.com>
marcromeyn
added a commit
that referenced
this pull request
Mar 10, 2026
* Fix broken links to usage-recipes (#9) Also updates a typo - usage cookbooks are now available, and examples are coming soon. Signed-off-by: Shashank Verma <shashank3959@gmail.com> * Final Pre-release commit (#10) * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Examples Directory Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * add Nemotron_Parse_V1_1.ipynb & Nemotron_Nano2_VL.ipynb to usage-cookbook * update Nemotron-Parse endpoint URL * docs: add Nemotron Ideas Portal feature voting section to README * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> * Final pre-release updates (#11) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Bug/rename notebook (#12) * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Final pre-release updates Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> --------- Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> * Nemotron Parse v1.1 and Nemotron Nano 2 VL notebook README.md (#13) Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> * Add Data Science ML Agent Use Case Example (#14) * Add Data Science ML Agent example Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Add data folder with .gitkeep Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README.md in use-case-examples Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * update the README in ds ml agent Signed-off-by: Allison Ding <allison.j.ding@gmail.com> --------- Signed-off-by: Allison Ding <allison.j.ding@gmail.com> * Adding structure Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data_prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding data-prep for nano-3 Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding nemotron.kit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Allowing defaults Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Integrate run Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fixing data prep Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Improving wandb artifact integration Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Various improvements Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes (#7) * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * End of day commit Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Remove tui for now (#8) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Removing tui properly (#9) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Move data-prep configs (#10) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Adding structure (#11) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Some fixes for pre-training (#12) Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Fix linting Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> * Disable CI for now Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> --------- Signed-off-by: Shashank Verma <shashank3959@gmail.com> Signed-off-by: Chris Alexiuk <calexiuk@nvidia.com> Signed-off-by: Chia-Chih Chen <chiachihc@nvidia.com> Signed-off-by: Allison Ding <allison.j.ding@gmail.com> Signed-off-by: Marc Romeyn <marcromeyn@gmail.com> Co-authored-by: Shashank Verma <shashank3959@gmail.com> Co-authored-by: Chris Alexiuk <161380339+chrisalexiuk-nvidia@users.noreply.github.com> Co-authored-by: Chia-Chih Chen <chiachihc@nvidia.com> Co-authored-by: Allison Ding <141533440+AllisonDing@users.noreply.github.com>
songCNMS
referenced
this pull request
in songCNMS/Nemotron
May 17, 2026
1. #7 Hermes 多轮：convert_hermes_conversations 不再在第一条 assistant 时 break，把所有 assistant + tool 轮收进 extra_env_info.expected_trajectory； 新增 expected_final_content / expected_turn_count。HERMES_ROLE_MAP 支持 tool / function / function_response / observation 四种 role。input_messages 仍只包含首条 assistant 前的上下文（不泄漏期望答案）；expected_tool_calls / expected_assistant_content 保留首轮值，向后兼容。 2. #8 hermes hf_config：显式锁定 func_calling_singleturn config（与 general_tool_calling 环境 max_turns=2 一致）；data_registry 注释解释了 为何 hermes 没有 hf_val_split（singleturn config 没有 holdout split， 继续走 fallback 警告路径）。 3. #15 aggregate 重复执行：拆出 score_rows（per-row 打分）与 aggregate_scored_rows（合并指标）两个纯函数；summarize_baselines 缓存 split 级 scored 行，aggregate 直接拼接 split 结果。对 code_execution_python 来说 subprocess fork 数量从 2× 降到 1×。 evaluate_policy 改成 score_rows + aggregate 的薄封装，签名不变。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
songCNMS
referenced
this pull request
in songCNMS/Nemotron
May 17, 2026
…级 3 项修复 (#5) * 【task002_m0_secondary_fixes】初始化 * 【task002_m0_secondary_fixes】M0 review 次优先级 3 项修复 1. #7 Hermes 多轮：convert_hermes_conversations 不再在第一条 assistant 时 break，把所有 assistant + tool 轮收进 extra_env_info.expected_trajectory； 新增 expected_final_content / expected_turn_count。HERMES_ROLE_MAP 支持 tool / function / function_response / observation 四种 role。input_messages 仍只包含首条 assistant 前的上下文（不泄漏期望答案）；expected_tool_calls / expected_assistant_content 保留首轮值，向后兼容。 2. #8 hermes hf_config：显式锁定 func_calling_singleturn config（与 general_tool_calling 环境 max_turns=2 一致）；data_registry 注释解释了 为何 hermes 没有 hf_val_split（singleturn config 没有 holdout split， 继续走 fallback 警告路径）。 3. #15 aggregate 重复执行：拆出 score_rows（per-row 打分）与 aggregate_scored_rows（合并指标）两个纯函数；summarize_baselines 缓存 split 级 scored 行，aggregate 直接拼接 split 结果。对 code_execution_python 来说 subprocess fork 数量从 2× 降到 1×。 evaluate_policy 改成 score_rows + aggregate 的薄封装，签名不变。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 【task002_m0_secondary_fixes】次优先级修复回归测试 新增 4 个 case： - hermes converter 保留 multi-turn trajectory 与 final content - data_registry hermes hf_config 显式为 func_calling_singleturn - summarize_baselines 不为 aggregate 重新评分（monkeypatch counter 验证） - score_rows + aggregate_scored_rows 与 evaluate_policy 行为等价 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * 【task002_m0_secondary_fixes】移除占位 WIP.md --------- Co-authored-by: intern_nemontron_review_cc <intern_nemontron_review_cc@intern.local> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial CI