docs(nooa_memory): correct the relative depth on the quickstart link 🤖🤖🤖 - #103
Merged
furgalep merged 1 commit intoAug 10, 2026
Merged
Conversation
This README sits at packages/nooa-memory/src/nooa_memory/, so reaching the repo
root takes four levels, not three. `../../../examples/quickstart/12_memory.py`
resolves to `packages/examples/quickstart/12_memory.py`, which does not exist, so
the link 404s on GitHub.
Verified from the file's own directory:
../../../examples/quickstart/12_memory.py -> packages/examples/... missing
../../../../examples/quickstart/12_memory.py -> examples/... exists
Same class as NVIDIA-NeMo#64, which fixed the tests/memory/ link in this file.
The remaining `examples/memory_bench/` references in this README are a separate
problem: that directory is absent at every depth, so no path adjustment fixes
them. Reported separately rather than guessed at here.
Signed-off-by: hotragn <hotragn.pettugani_2024@woxsen.edu.in>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the relative depth on the quickstart link in
packages/nooa-memory/src/nooa_memory/README.md. The file sits four levels below the repo root, not three, so the link 404s on GitHub.Verified from the file's own directory:
Same class as #64, which fixed the
tests/memory/link in this same file.I found it by resolving every relative markdown link in the repo rather than by reading — it's the only depth-bug of its kind left, and every other relative link in the tree resolves.
Related issues
None. Separately: the four remaining
examples/memory_bench/references in this README (lines 8, 303, 401, 449) point at a directory that is absent at every depth, so no path adjustment fixes them — I've filed that as its own issue rather than guess at the intended target here, since the right answer is either publishing the directory or dropping the references, and that's a maintainer call.Checklist
uv run ruff check .anduv run ruff format --check .pass)uv run pytest) — docs-only, no test surface🤖🤖🤖