chore: remove unused ShellToolsLegacy - #21
Merged
Conversation
`src/nooa/tools/shell_tools_legacy.py` was dead code. Nothing in `src/`, `examples/`, or `packages/` imported it: both bench agents and the tools package `__init__` use the modern `nooa.tools.shell_tools.ShellTools`. Its only consumers were five test modules that existed solely to exercise it. Removed: - `src/nooa/tools/shell_tools_legacy.py` - `tests/tools/test_shell_tools.py` - `tests/tools/test_edit_regressions.py` - `tests/tools/test_grep_timeout.py` - `tests/tools/test_shell_tools_rg_fallback.py` These four suites target legacy-only methods (`view`, `edit`, `insert`, `grep`, `find`, `ls`, `reset`) that have no counterpart on the modern `ShellTools`, so there is nothing to port. The modern surface stays covered by `test_shell_tools_modern.py` and `test_shell_tools_modern_behavior.py`. Kept, repointed at the modern `ShellTools`: - `tests/tools/test_bash_cross_loop.py` — the gl-212 cross-loop `Lock` regression is about `BashSession`, not the legacy wrapper, and its `ShellTools` case only uses `run()`, which both classes provide. Also dropped a stale docstring reference to the deleted legacy suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/nooa/tools/shell_tools_legacy.pywas dead code. Nothing insrc/,examples/, orpackages/imported it: both bench agents and the tools package__init__use the modernnooa.tools.shell_tools.ShellTools. Its only consumers were five test modules that existed solely to exercise it.Removed:
src/nooa/tools/shell_tools_legacy.pytests/tools/test_shell_tools.pytests/tools/test_edit_regressions.pytests/tools/test_grep_timeout.pytests/tools/test_shell_tools_rg_fallback.pyThese four suites target legacy-only methods (
view,edit,insert,grep,find,ls,reset) that have no counterpart on the modernShellTools, so there is nothing to port. The modern surface stays covered bytest_shell_tools_modern.pyandtest_shell_tools_modern_behavior.py.Kept, repointed at the modern
ShellTools:tests/tools/test_bash_cross_loop.py— the gl-212 cross-loopLockregression is aboutBashSession, not the legacy wrapper, and itsShellToolscase only usesrun(), which both classes provide.Also dropped a stale docstring reference to the deleted legacy suite.
What does this PR do?
Related issues
Checklist
uv run ruff check .anduv run ruff format --check .pass)uv run pytest)