Skip to content

fix(examples): support commit SHAs for git_ref in the Harbor adapter 🤖🤖🤖 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdasilveiracabral merged 1 commit into from
Jul 31, 2026
Merged

fix(examples): support commit SHAs for git_ref in the Harbor adapter 🤖🤖🤖 #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions examples/benchmarks/harbor_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class NooaBenchAgent(BaseInstalledAgent):

YAML kwargs:
git_url: clone URL of the NOOA repo (or env ``NOOA_GIT_URL``)
git_ref: optional branch/tag/SHA (or env ``NOOA_GIT_REF``)
git_ref: optional branch/tag/full commit SHA (or env ``NOOA_GIT_REF``)
agent_type: registry key passed to ``nemo-harbor`` (default ``bench``)
api_base: optional OpenAI-compatible endpoint override
"""
Expand Down Expand Up @@ -83,14 +83,25 @@ def name() -> str:

async def install(self, environment: BaseEnvironment) -> None:
"""Clone the repo and install core + cli + bench into a fresh venv."""
branch = f"--branch {shlex.quote(self._git_ref)} " if self._git_ref else ""
url = shlex.quote(self._git_url)
if self._git_ref:
# `git clone --branch` rejects commit SHAs; fetching the ref and
# checking out FETCH_HEAD handles branches, tags, and full SHAs alike.
clone = (
f"mkdir -p {REPO_DIR} && cd {REPO_DIR} && git init -q && "
f"git remote add origin {url} && "
f"git fetch -q --depth 1 origin {shlex.quote(self._git_ref)} && "
"git checkout -q FETCH_HEAD"
)
else:
clone = f"git clone --depth 1 {url} {REPO_DIR}"
await self.exec_as_root(
environment,
command=(
# git may be missing from slim task images; best-effort install.
"(which git > /dev/null 2>&1 || "
"(apt-get update && apt-get install -y git curl)) && "
f"git clone --depth 1 {branch}{shlex.quote(self._git_url)} {REPO_DIR} && "
f"{clone} && "
# uv gives us a venv + resolver without assuming pip exists.
"(which uv > /dev/null 2>&1 || "
"(curl -LsSf https://astral.sh/uv/install.sh | sh)) && "
Expand Down
Loading