fix(e2e): retry unstable publication pagination

[senthilr-nv]

Summary

The E2E publication gate now discards a partial workflow-run traversal and restarts from page 1 when GitHub reports a concurrent count change. This fixes main E2E run 31865751841, jobs 94966592045 and 94967770635, while still accepting evidence only from a complete stable traversal.

Changes

• Retry publication pagination from page 1 after a workflow-run or publisher-job count change.
• Bound collection to three attempts and preserve fail-closed handling for duplicate, incomplete, malformed, or over-cap evidence.
• Cover recovery from one concurrent count change and rejection after persistent instability.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: This changes only the internal trusted E2E publication collector and does not change a supported user command, flag, configuration, API, policy, default, or runtime behavior.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: The final diff changes only the internal E2E publication collector and its focused tests; repository documentation does not describe this GitHub evidence-pagination algorithm.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — ./node_modules/.bin/vitest run --project e2e-support test/e2e/support/base-image-publication.test.ts --reporter=verbose completed with 42 passed.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: The host aggregate E2E-support run completed with 2,393 passed, 18 skipped, and 8 unrelated macOS/BSD or timing failures; the changed publication suite passed. npm run validate:pr passed.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Senthil Ravichandran senthilr@nvidia.com

Summary by CodeRabbit

• Bug Fixes

  • Improved workflow-run pagination when result counts change during retrieval.
  • Automatically retries inconsistent pagination results up to three times.
  • Reports a clear failure when pagination remains unstable after all retries.

• Tests

  • Added coverage for successful retries, stable complete results, and repeated pagination failures.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3729c02e-9bb9-4e01-8d89-4ee905bb00d5

📥 Commits

Reviewing files that changed from the base of the PR and between 7b1c064 and 45247a2.

📒 Files selected for processing (2)

• test/e2e/support/base-image-publication.test.ts
• tools/e2e/base-image-publication.mts

---

📝 Walkthrough

Walkthrough

The pagination collector now retries inconsistent workflow-run responses up to three times. It returns the first stable collection and reports failure after repeated total changes. End-to-end tests cover both recovery and bounded failure behavior.

Changes

Pagination consistency retries

Layer / File(s)	Summary
Retryable pagination flow tools/e2e/base-image-publication.mts	Pagination uses a single-attempt helper and retries inconsistent total_count results up to three times. Existing page, count, duplicate-ID, and safety-cap validation remains enforced.
Pagination retry coverage test/e2e/support/base-image-publication.test.ts	Tests verify that pagination restarts after a changing total and fails after three unstable attempts with six requests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 45247

This localized change retries unstable publication pagination while preserving fail-closed validation, with targeted tests and required validation reported as passing; no actionable merge-blocking risk remains.

Possibly related PRs

• NVIDIA/NemoClaw#9179: Adds related bounded-retry logic and retry-focused end-to-end tests.

Suggested reviewers: brandonpelfrey

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: retrying unstable pagination in the E2E publication flow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-base-image-publication-pagination

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 45247a2 in the codex/fix-base-image... branch remains at 96%, unchanged from commit 7b1c064 in the main branch.

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Failed after a partial review · low confidence · 0 blockers · 0 warnings · 0 suggestions

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

2 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• justified — concurrent workflow-run count change at test/e2e/support/base-image-publication.test.ts:399: Retain the term in the test title because it names the retry condition.
• justified — unstable pagination at test/e2e/support/base-image-publication.test.ts:427: Retain the term in the test title because it distinguishes persistent instability from a recovered count change.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Manual-only E2E: cloud-onboard, security-posture, cloud-inference
The manual PR workflow does not run these selectors for the commit under review. Run them from reviewed code on main.

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.