-
Notifications
You must be signed in to change notification settings - Fork 3k
test(cli): guard inference set config read exit code #9322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+128
−6
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5b0217d
test(cli): guard inference set config read exit code
rsliter 2ef2c30
test(cli): assert failed inference set preserves state
rsliter 7a69f03
ci: retrigger dynamic code scanning
prekshivyas 7337545
merge(onboard): sync main and restore messaging dependencies
prekshivyas d269a3a
merge: resolve conflicts with main
github-actions[bot] 6b953d0
ci: trigger checks after automated main sync
prekshivyas d7cda36
test(e2e): align launchable authorization retry fixture
prekshivyas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { spawnSync } from "node:child_process"; | ||
| import fs from "node:fs"; | ||
| import os from "node:os"; | ||
| import path from "node:path"; | ||
|
|
||
| import { afterEach, beforeEach, describe, expect, it } from "vitest"; | ||
| import { testTimeoutOptions } from "./helpers/timeouts"; | ||
|
|
||
| const CLI = path.join(import.meta.dirname, "..", "bin", "nemoclaw.js"); | ||
| const SANDBOX = "issue-9104-alpha"; | ||
|
|
||
| describe("inference set sandbox configuration read failures", () => { | ||
| let home: string; | ||
| let openshell: string; | ||
| let openshellLog: string; | ||
|
|
||
| beforeEach(() => { | ||
| home = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-9104-")); | ||
| openshell = path.join(home, "openshell"); | ||
| openshellLog = path.join(home, "openshell.log"); | ||
| fs.writeFileSync( | ||
| openshell, | ||
| [ | ||
| "#!/usr/bin/env bash", | ||
| `printf '%s\\n' "$*" >> ${JSON.stringify(openshellLog)}`, | ||
| "printf '%s\\n' 'exec session setup failed: container not ready' >&2", | ||
| "exit 1", | ||
| ].join("\n"), | ||
| { mode: 0o755 }, | ||
| ); | ||
|
|
||
| const registryDir = path.join(home, ".nemoclaw"); | ||
| fs.mkdirSync(registryDir, { recursive: true }); | ||
| fs.writeFileSync( | ||
| path.join(registryDir, "sandboxes.json"), | ||
| JSON.stringify({ | ||
| sandboxes: { | ||
| [SANDBOX]: { | ||
| agent: "openclaw", | ||
| gpuEnabled: false, | ||
| model: "nvidia/llama-3.3-nemotron-super-49b-v1", | ||
| name: SANDBOX, | ||
| policies: [], | ||
| provider: "nvidia-prod", | ||
| }, | ||
| }, | ||
| defaultSandbox: SANDBOX, | ||
| }), | ||
| { mode: 0o600 }, | ||
| ); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| fs.rmSync(home, { force: true, recursive: true }); | ||
| }); | ||
|
|
||
| it.each([ | ||
| [ | ||
| "global", | ||
| [ | ||
| "inference", | ||
| "set", | ||
| "--provider", | ||
| "nvidia-prod", | ||
| "--model", | ||
| "nvidia/nemotron-3-nano-omni-30b-a3b-reasoning", | ||
| "--sandbox", | ||
| SANDBOX, | ||
| "--no-verify", | ||
| ], | ||
| ], | ||
| [ | ||
| "sandbox-first", | ||
| [ | ||
| SANDBOX, | ||
| "inference", | ||
| "set", | ||
| "--provider", | ||
| "nvidia-prod", | ||
| "--model", | ||
| "nvidia/nemotron-3-nano-omni-30b-a3b-reasoning", | ||
| "--no-verify", | ||
| ], | ||
| ], | ||
| ])( | ||
| "%s inference set exits with status 1 when OpenShell cannot read the sandbox configuration (#9104)", | ||
| testTimeoutOptions(30_000), | ||
| (_grammar, argv) => { | ||
| const result = spawnSync(process.execPath, [CLI, ...argv], { | ||
| encoding: "utf8", | ||
| env: { | ||
| ...process.env, | ||
| HOME: home, | ||
| NEMOCLAW_OPENSHELL_BIN: openshell, | ||
| NEMOCLAW_STATUS_PROBE_TIMEOUT_MS: "2000", | ||
| NEMOCLAW_TEST_NO_SLEEP: "1", | ||
| }, | ||
| killSignal: "SIGKILL", | ||
| timeout: 30_000, | ||
| }); | ||
| const output = `${result.stdout ?? ""}\n${result.stderr ?? ""}`; | ||
|
|
||
| expect(result.error).toBeUndefined(); | ||
| expect(result.signal).toBeNull(); | ||
| expect(output).toContain("Cannot read openclaw config (/sandbox/.openclaw/openclaw.json)"); | ||
| const openshellCalls = fs.readFileSync(openshellLog, "utf8").trim().split("\n"); | ||
| expect(openshellCalls).toHaveLength(1); | ||
| expect(openshellCalls[0]).toContain("sandbox exec"); | ||
| expect(openshellCalls[0]).toContain("cat /sandbox/.openclaw/openclaw.json"); | ||
| expect(openshellCalls).not.toContainEqual(expect.stringMatching(/\binference set\b/u)); | ||
| expect(result.status).toBe(1); | ||
| }, | ||
| ); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.