Skip to content

Commit 3bf7702

Browse files
committed
docs(defaults): scope the kube-version invariant to the constant
Review feedback: the invariant sentence read as though it bound the whole kube-version resolution path. It does not. KubeVersionFromConstraints returns the recipe's own value, and extractVersion(">= 1.25") yields "1.25", so a recipe carrying only base.yaml's floor renders with --kube-version 1.25 — below the stated invariant. Scope the sentence to this constant and note that the constraint path is unbounded below, so the comment cannot be read as a guarantee about rendering in general. Comment-only; no behavior change. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
1 parent 47fbd07 commit 3bf7702

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

pkg/defaults/timeouts.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,12 +1255,17 @@ const (
12551255
// default (currently v1.27.0 in Helm 3.x), which is too old for
12561256
// charts that declare a kubeVersion constraint (e.g., >=1.32.0-0).
12571257
//
1258-
// This is a render-safe fallback, not a support floor. It must stay at
1259-
// or above the strictest kubeVersion any bundled chart declares. Do NOT
1260-
// lower it to match the ">= 1.25" recipe floor in
1258+
// This is a render-safe fallback, not a support floor. This constant
1259+
// must stay at or above the strictest kubeVersion any bundled chart
1260+
// declares. Do NOT lower it to match the ">= 1.25" recipe floor in
12611261
// recipes/overlays/base.yaml: that is the constraint recipes are
12621262
// validated against, and a recipe that declares one never reaches this
12631263
// default (see mirror.KubeVersionFromConstraints).
1264+
//
1265+
// The invariant binds this constant only. The constraint path is
1266+
// unbounded below: KubeVersionFromConstraints returns the recipe's own
1267+
// value, so a recipe carrying nothing but base.yaml's ">= 1.25" renders
1268+
// with --kube-version 1.25.
12641269
MirrorDefaultKubeVersion = "1.33.0"
12651270

12661271
// MirrorDiscoveryConcurrency caps the number of components rendered in

0 commit comments

Comments
 (0)