Commit 3bf7702
committed
docs(defaults): scope the kube-version invariant to the constant
Review feedback: the invariant sentence read as though it bound the whole
kube-version resolution path. It does not. KubeVersionFromConstraints
returns the recipe's own value, and extractVersion(">= 1.25") yields
"1.25", so a recipe carrying only base.yaml's floor renders with
--kube-version 1.25 — below the stated invariant.
Scope the sentence to this constant and note that the constraint path is
unbounded below, so the comment cannot be read as a guarantee about
rendering in general.
Comment-only; no behavior change.
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>1 parent 47fbd07 commit 3bf7702
1 file changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1255 | 1255 | | |
1256 | 1256 | | |
1257 | 1257 | | |
1258 | | - | |
1259 | | - | |
1260 | | - | |
| 1258 | + | |
| 1259 | + | |
| 1260 | + | |
1261 | 1261 | | |
1262 | 1262 | | |
1263 | 1263 | | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
1264 | 1269 | | |
1265 | 1270 | | |
1266 | 1271 | | |
| |||
0 commit comments