Skip to content

Commit 9035485

Browse files
committed
chore(renovate): describe the daemon ignoreDeps entry as pre-emptive
Review correction: the entry is not an active drift guard today. The kubernetes manager is narrowed to recipes/components/*/manifests, and tcpgpudmarxd-dev appears only in demos/ and validators/**/testdata/, so Renovate never extracts it. The previous comment claimed symmetry with the installer entry, which overstates what the config does now. Keep the entry -- it prevents a future widening of those patterns from letting the daemon move alone -- but say what it actually is. Also unify the wording for the same Google URL: the demo header called it a 'release table' while the integrator doc calls it 'release notes'. Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
1 parent d5110a6 commit 9035485

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

.github/renovate.json5

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -363,10 +363,13 @@
363363
// workload-side daemon (tcpgpudmarxd-dev) must move together; an
364364
// independent Renovate bump on this image alone would create
365365
// stack version skew. See docs/integrator/gke-tcpxo-networking.md.
366-
// - tcpgpudmarxd-dev: the workload-side half of the same TCPXO pair. Listed
367-
// alongside the installer so the coupling is symmetric — excluding only
368-
// the installer would leave the daemon free to move on its own, which is
369-
// the same stack version skew from the opposite direction.
366+
// - tcpgpudmarxd-dev: the workload-side half of the same TCPXO pair.
367+
// Pre-emptive rather than an active guard today: the kubernetes manager
368+
// above is narrowed to recipes/components/*/manifests, and the daemon
369+
// appears only in demos/ and validators/**/testdata/, so Renovate does not
370+
// extract it at present. Listed so that widening those patterns cannot
371+
// silently let the daemon move on its own — the same stack version skew as
372+
// bumping the installer alone, from the opposite direction.
370373
ignoreDeps: [
371374
"602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/aws-efa-k8s-device-plugin",
372375
"us-docker.pkg.dev/gce-ai-infra/gpudirect-tcpxo/nccl-plugin-gpudirecttcpx-dev",

demos/workloads/training/gke-nccl-test-tcpxo.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
# kubectl get ds nccl-tcpxo-installer -n kube-system \
4242
# -o jsonpath='{.spec.template.spec.initContainers[?(@.name=="nccl-tcpxo-installer")].image}'
4343
# then update BOTH images below to that installer's pair, per Google's
44-
# release table: https://github.com/GoogleCloudPlatform/container-engine-accelerators/blob/master/gpudirect-tcpxo/README.md
44+
# release notes: https://github.com/GoogleCloudPlatform/container-engine-accelerators/blob/master/gpudirect-tcpxo/README.md
4545
# Updating only one half recreates the mismatch this pairing exists to avoid.
4646
#
4747
# Usage:

0 commit comments

Comments
 (0)