Skip to content

chore(ci): add srao-nv to copy-pr-bot additional trustees - #2354

Merged
njhensley merged 4 commits into
mainfrom
chore/copy-pr-bot-add-srao-nv
Aug 25, 2026
Merged

chore(ci): add srao-nv to copy-pr-bot additional trustees#2354
njhensley merged 4 commits into
mainfrom
chore/copy-pr-bot-add-srao-nv

Conversation

@srao-nv

@srao-nv srao-nv commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Adds srao-nv to the additional_trustees list in .github/copy-pr-bot.yaml so the copy-pr-bot honors copy requests from this account.

Signed-off-by: Sujan Rao <sujan@nvidia.com>
@srao-nv
srao-nv requested a review from a team as a code owner August 24, 2026 14:58
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: ce9ce766-fa12-4aeb-859d-b42037547481

📥 Commits

Reviewing files that changed from the base of the PR and between 26eef38 and b29d2b0.

📒 Files selected for processing (1)
  • .github/copy-pr-bot.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The copy PR bot configuration adds srao-nv to the additional_trustees list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b29d2

This localized CI configuration change adds the requested trustee account, and no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: arangogutierrez

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the configuration change and the account added to the copy-pr-bot trustee list.
Description check ✅ Passed The description accurately explains that the configuration change enables copy-pr-bot requests from srao-nv.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/copy-pr-bot-add-srao-nv

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Coverage Report ✅

Metric Value
Coverage 84.1%
Threshold 80%
Status Pass
Coverage Badge
![Coverage](https://img.shields.io/badge/coverage-84.1%25-brightgreen)

No Go source files changed in this PR.

@njhensley njhensley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — multi-persona (trust/security lens), adversarially grounded

Approve.

Single-line addition of srao-nv (Sujan Rao) to additional_trustees in .github/copy-pr-bot.yaml.

Verified for the one lens that matters here:

  • Legitimacysrao-nv is a confirmed public member of the NVIDIA org; account created 2026-02-25.
  • Vouching — self-add, but approved by existing trustee + maintainer @mchmarny (the required control).
  • Blast radius — the list is consumed by the copy-pr-bot GitHub App, not by ok-to-test.yaml (which gates independently on repo admin/write/maintain). Adding a vetted org member doesn't weaken the privileged fork-PR CI path, which stays gated with privileged_ci: false.
  • Consistency — matches the shape of the last several additions (bmcadams1 #2188, varmesh #2030, rorajani #2014), appended at list end.
  • CI — all required checks green.

Findings: 🔴 0 | 🟠 0 | 🟡 0 | 🔵 0. No defects; nothing to change.

@njhensley
njhensley enabled auto-merge (squash) August 25, 2026 21:47
@njhensley
njhensley merged commit fbc0ed6 into main Aug 25, 2026
39 of 40 checks passed
@njhensley
njhensley deleted the chore/copy-pr-bot-add-srao-nv branch August 25, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants