Handle adjoint rotations in gate decompositions#4210
Draft
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Handle adjoint rotations in gate decompositions#4210lmondada wants to merge 2 commits intoNVIDIA:mainfrom
lmondada wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Collaborator
Author
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting gate decompositions, we were not distinguishing adjoint gates from their non-adjoint counterparts. This meant that we never selected decompositions such as
RxAdjToRx, as the automatic selection algorithm was viewing it as a no-op and hence useless.This PR fixes this.
Note that this would also allow us to distinguish between
S/Tand their adjoint, but this would require adding more decomposition rules and would not benefit us at the moment (because whereverSandTare supported we currently also support the adjoint forms).